Skip to content

Added definitions for Arduino 1.6.0 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

z3t0
Copy link
Contributor

@z3t0 z3t0 commented Mar 18, 2015

Please review this PR as it should be stable. This was generated using my arduvim plugin so for the best support please install that and use it because it generates syntax definitions on the go.

@z3t0
Copy link
Contributor Author

z3t0 commented Mar 18, 2015

@Jaidan please take a look at this PR and also the plugin mentioned above.

@sudar
Copy link
Owner

sudar commented Mar 24, 2015

@z3t0 This pull request still has some issues.

I have commented about it in the commit.

@z3t0
Copy link
Contributor Author

z3t0 commented Mar 24, 2015

@sudar Please take a look at merging the README as well, since it is much more informative and also has more install instructions.

There is no point in having library specific definitions as they do not do anything.
@sudar
Copy link
Owner

sudar commented Mar 27, 2015

@z3t0 This pull request has the following issues.

  • Highlights are defined for arduinoStdFunc, arduinoMethod, arduinoIdentifier, arduinoOperator but they are not present in the syntax files.
  • Serial Serial1 Serial2 Serial3 etc should be highlighted as Identifier and not as functions.

@z3t0
Copy link
Contributor Author

z3t0 commented Mar 28, 2015

@sudar I will take a look and make another commit once I work through the above mentioned issues. Thanks for the feedback!

@z3t0
Copy link
Contributor Author

z3t0 commented Apr 10, 2015

@sudar I apologize for the delay, exciting things going on at voxel.js!

@sudar
Copy link
Owner

sudar commented Apr 10, 2015

No problem. Take your time.

On Fri, Apr 10, 2015 at 10:18 AM, Rafi Khan notifications@github.com
wrote:

@sudar https://github.com/sudar I apologize for the delay, exciting
things going on at voxel.js!


Reply to this email directly or view it on GitHub
#10 (comment)
.

@z3t0
Copy link
Contributor Author

z3t0 commented Apr 10, 2015

@sudar OK, the latest commit should fix things

@sudar sudar closed this in 0d85f61 Apr 27, 2015
@sudar
Copy link
Owner

sudar commented Apr 27, 2015

@z3t0 Thanks for fixing it.

This PR was not merging, so I picked your changes and committed them.

I have added your name in credit section of both in the syntax file and the in the README file.

Thanks for all the hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants