-
Notifications
You must be signed in to change notification settings - Fork 17
Added definitions for Arduino 1.6.0 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Jaidan please take a look at this PR and also the plugin mentioned above. |
@z3t0 This pull request still has some issues. I have commented about it in the commit. |
@sudar Please take a look at merging the README as well, since it is much more informative and also has more install instructions. |
There is no point in having library specific definitions as they do not do anything.
@z3t0 This pull request has the following issues.
|
@sudar I will take a look and make another commit once I work through the above mentioned issues. Thanks for the feedback! |
@sudar I apologize for the delay, exciting things going on at voxel.js! |
No problem. Take your time. On Fri, Apr 10, 2015 at 10:18 AM, Rafi Khan notifications@github.com
|
@sudar OK, the latest commit should fix things |
@z3t0 Thanks for fixing it. This PR was not merging, so I picked your changes and committed them. I have added your name in credit section of both in the syntax file and the in the README file. Thanks for all the hard work. |
Please review this PR as it should be stable. This was generated using my arduvim plugin so for the best support please install that and use it because it generates syntax definitions on the go.