Repository navigation
fix(sdk): require HTTPS for bearer tokens - #2961
Open
felix314159 wants to merge 1 commit into
Open
felix314159 wants to merge 1 commit into
felix314159 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
NetworkProverBuildersupports both custom RPC URLs and bearer-token authentication. before this pr, combining a bearer token with anhttp://RPC URL caused the SDK to send the reusableAuthorizationcredential over a plaintext HTTP/2 connection, so a malicious network observer would have been able to recover the token and use any privileges it grants until it expires or is refreshed..the endpoint already requires HTTPS for mTLS client identities, so this change applies the same transport requirement to bearer tokens and returns an error before creating the plaintext connection.