fix: Rename gpu_time → gpu_ms in TaskMetadata#2651
Open
fakedev9999 wants to merge 1 commit intomultilinear_v6from
Open
fix: Rename gpu_time → gpu_ms in TaskMetadata#2651fakedev9999 wants to merge 1 commit intomultilinear_v6from
fakedev9999 wants to merge 1 commit intomultilinear_v6from
Conversation
Unify field naming between sp1_prover and sp1-cluster coordinator. Worker sends TaskMetadata with this field, and coordinator expects gpu_ms. This rename fixes the source instead of relying on serde alias workaround. Fixes cloud-ops#61
Contributor
|
tamirhemo
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Worker sends
TaskMetadata { gpu_time: Option<u64> }, but coordinator expectsgpu_ms: u64. This field name mismatch causestenant_gpu_busy_timeto always emit 0. A short-term serde alias was added in sp1-cluster#60 as a workaround.Solution
Rename
gpu_time→gpu_msinTaskMetadatastruct definition and all usages. This unifies the field name at the source instead of relying on serde alias compatibility.Fixes cloud-ops#61
PR Checklist