Skip to content

fix(sdk): cancel_request result #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

fix(sdk): cancel_request result #2434

merged 2 commits into from
Aug 22, 2025

Conversation

0xernesto
Copy link
Contributor

@0xernesto 0xernesto commented Aug 22, 2025

Remove semicolon to fix expected Result<(), Error>, found ()

@0xernesto 0xernesto requested a review from mattstam August 22, 2025 21:14
@0xernesto 0xernesto merged commit dc8c999 into dev Aug 22, 2025
11 of 12 checks passed
@0xernesto 0xernesto deleted the ernesto/fix-result branch August 22, 2025 21:22
Copy link
Contributor

github-actions bot commented Aug 22, 2025

Test Old New Diff
curve25519_dalek_ng_test_zero_mul 197063 197063 0.0000 %
p256_test_recover_pubkey_infinity 143003 143003 0.0000 %
bls12_381_tests_test_bls_double_100 9218745 9218745 0.0000 %
curve25519_dalek_test_zero_mul 197103 197103 0.0000 %
curve25519_dalek_test_decompressed_expected_value 16150463 15231050 -5.6928 %
k256_test_recover_high_hash_high_recid 2593051 2780029 7.2107 %
secp256k1_program_test_verify_v0_30_0_rand_lte_100 46832441 46902114 0.1488 %
bls12_381_tests_test_sqrt_fp_100 1006947 1020318 1.3279 %
bn_test_bn_test_g1_add_100 846324 846331 0.0008 %
bn_test_bn_test_fq_sqrt_100 763356 763356 0.0000 %
bls12_381_tests_test_inverse_fp_100 1375050 1375050 0.0000 %
k256_test_schnorr_verify 7040977 7035438 -0.0787 %
keccack_test_expected_digest_lte_100 2032560 2038090 0.2721 %
curve25519_dalek_test_zero_msm 213024 213024 0.0000 %
curve25519_dalek_test_add_then_multiply 7040735 7061723 0.2981 %
bls12_381_tests_test_sqrt_fp2_100 2134524 1730349 -18.9351 %
curve25519_dalek_ng_test_zero_msm 216592 216592 0.0000 %
bls12_381_tests_test_bls_add_100 15763438 15763438 0.0000 %
k256_test_verify_rand_lte_100 24811828 24834064 0.0896 %
curve25519_dalek_test_ed25519_verify 32352546 32350103 -0.0076 %
rust_crypto_rsa_test_pkcs_verify_100 101835438 101985180 0.1470 %
sha_test_sha2_v0_9_9_expected_digest_lte_100_times 1490103 1488165 -0.1301 %
sha_test_sha2_v0_10_6_expected_digest_lte_100_times 1739030 1732692 -0.3645 %
curve25519_dalek_ng_test_decompressed_noncanonical 206954 206954 0.0000 %
sha_test_sha2_v0_10_8_expected_digest_lte_100_times 1730164 1730499 0.0194 %
rustcrypto_bigint_test_bigint_mul_mod_special 2315020 2315020 0.0000 %
p256_test_recover_rand_lte_100 7267776 7254684 -0.1801 %
secp256k1_program_test_verify_rand_lte_100 46848933 46778569 -0.1502 %
bn_test_bn_test_fr_inverse_100 796856 796856 0.0000 %
secp256k1_program_test_recover_v0_30_0_rand_lte_100 6647048 6636586 -0.1574 %
bn_test_bn_test_g1_double_100 648027 648048 0.0032 %
curve25519_dalek_ng_test_add_then_multiply 7616851 6245689 -18.0017 %
rustcrypto_bigint_test_bigint_mul_add_residue 2253569 2253569 0.0000 %
k256_test_recover_rand_lte_100 5608787 5597277 -0.2052 %
secp256k1_program_test_recover_rand_lte_100 6601917 6601739 -0.0027 %
k256_test_recover_pubkey_infinity 124534 124534 0.0000 %
sha_test_sha3_expected_digest_lte_100_times 1668862 1668797 -0.0039 %
p256_test_verify_rand_lte_100 24848549 24844041 -0.0181 %
bls12_381_tests_test_inverse_fp2_100 3083020 3083020 0.0000 %
curve25519_dalek_test_decompressed_noncanonical 9169 9169 0.0000 %
p256_test_recover_high_hash_high_recid 3057506 3622994 18.4951 %
bn_test_bn_test_fq_inverse_100 766356 766356 0.0000 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants