Skip to content

Conversation

LHerskind
Copy link

This pr addresses a few oddities I ran into when trying out your template.

  1. The testFail have deprecated in foundry with the stable releases, so updated to be more specific there.
  2. The tests just mocked a fake verifier saying yes so I updated it to instead deploy the real verifiers and then use those for the checks. I know you prefer the gateway, but with the split it seemed useful to be very explicit about the verifier.

Saw some oddities with the error naming in groth16 and created an issue in succinctlabs/sp1-contracts#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant