General housekeeping #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstogner
force-pushed
the
housekeeping
branch
2 times, most recently
from
4e78b44
to
315e8cd
Compare
nstogner
force-pushed
the
housekeeping
branch
from
315e8cd
to
560ce1f
Compare
samos123
reviewed
Jan 15, 2024
| @@ -1,4 +1,4 @@ | |||
| name: Create and publish a Docker image | |||
| name: Build and Push | |||
There was a problem hiding this comment.
Build and Push Container Image?
There was a problem hiding this comment.
I am fine reverting, but the reason I made these changes: "Build and Push" as the title of the workflow and "container" as what is being built and pushed. I think it displays nicely on the output.
samos123
reviewed
Jan 15, 2024
samos123
reviewed
Jan 15, 2024
samos123
reviewed
Jan 15, 2024
README.md
Outdated
| @@ -1,36 +1,41 @@ | |||
| # Lingo - K8s LLM Proxy + Scaler | |||
| # Lingo - The lightweight model proxy | |||
There was a problem hiding this comment.
I do think we should add K8s in the title so it's clear that this only works on K8s and is very focused towards K8s.
What about one of these options?
- The lightweight ML Model proxy and autoscaler for K8s
- Lightweight K8s ML Proxy and Autoscaler
- K8s ML Proxy and Autoscaler
There was a problem hiding this comment.
What about leaving the title block just the name (# Lingo) and keeping the description in the description section of the repo? I feel like these are too long for an H1.
samos123
requested changes
Jan 15, 2024
samos123
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: No actual changes to testing code were made. Changes to workflow files are mostly for readability of files and also of the checks as displayed on PRs.