feat: add antlr grammar for test file format #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgkiran
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
|
Would it make sense to split this into 2 PRs, one for the type grammar which is effectively just an import of the existing grammar from substrait-java, and then one for the new test grammar which requires more careful review? |
scgkiran
force-pushed
the
testcase-grammar-parser
branch
from
c97a231
to
e9e02bd
Compare
scgkiran
changed the title
EpsilonPrime
reviewed
Nov 4, 2024
EpsilonPrime
reviewed
Nov 5, 2024
Add parser changes for testcase files Add function test coverage changes
scgkiran
force-pushed
the
testcase-grammar-parser
branch
from
a2e09a9
to
b6a0cbf
Compare
EpsilonPrime
approved these changes
Nov 5, 2024
jacques-n
approved these changes
Nov 7, 2024
I will do it in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parser changes for testcase files
Add function test coverage changes