feat: geometry processing functions #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtia
requested review from
jacques-n,
cpcloud and
westonpace
as code owners
EpsilonPrime
previously approved these changes
Sep 19, 2023
vbarua
reviewed
Sep 20, 2023
extensions/functions_geometry.yaml
Outdated
| name: geom | ||
| - value: fp64 | ||
| name: buffer_radius | ||
| return: geometry |
There was a problem hiding this comment.
What geometry type is this referencing?
There was a problem hiding this comment.
the geometry type is supposed to be a list of simple geometries defined in this PR: https://github.com/substrait-io/substrait/pull/543/files#diff-130b5d19a0015ea70d9adfa93d28ab07d70d340f02085bbeefcf1b875b154d84
There was a problem hiding this comment.
EpsilonPrime
previously approved these changes
Sep 26, 2023
richtia
force-pushed
the
geometry_processing
branch
from
8444238
to
e96db77
Compare
EpsilonPrime
previously approved these changes
Sep 29, 2023
richtia
force-pushed
the
geometry_processing
branch
from
e96db77
to
078e463
Compare
EpsilonPrime
approved these changes
Oct 2, 2023
paleolimbot
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add geometry processing functions