feat: add any_value aggregate function #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanstraten
changed the title
jvanstraten
reviewed
Sep 8, 2022
vibhatha
force-pushed
the
aggregate-any_value
branch
from
70c6851
to
eadc4fb
Compare
|
@jvanstraten I updated the PR. |
vibhatha
changed the title
|
Sorry, I don't know why I didn't notice this before, but there's no reason for this to be limited to numeric types. It can just be |
|
@jvanstraten updated the PR. |
jvanstraten
requested changes
Sep 12, 2022
extensions/functions_arithmetic.yaml
Outdated
Comment on lines
1371
to
1407
|
|
||
| - name: "any_value" | ||
| description: > | ||
| Selects an arbitrary value from a group of values. | ||
|
|
||
| If the input is empty, the function returns null. | ||
| impls: | ||
| - args: | ||
| - name: x | ||
| value: i8 | ||
| nullability: DECLARED_OUTPUT | ||
| return: i8? | ||
| - args: | ||
| - name: x | ||
| value: i16 | ||
| nullability: DECLARED_OUTPUT | ||
| return: i16? | ||
| - args: | ||
| - name: x | ||
| value: i32 | ||
| nullability: DECLARED_OUTPUT | ||
| return: i32? | ||
| - args: | ||
| - name: x | ||
| value: i64 | ||
| nullability: DECLARED_OUTPUT | ||
| return: i64? | ||
| - args: | ||
| - name: x | ||
| value: fp32 | ||
| nullability: DECLARED_OUTPUT | ||
| return: fp32? | ||
| - args: | ||
| - name: x | ||
| value: fp64 | ||
| nullability: DECLARED_OUTPUT | ||
| return: fp64? |
There was a problem hiding this comment.
This is completely covered by the f(any) -> any? variant, and it isn't really an arithmetic function to begin with. So why is this still here?
vibhatha
force-pushed
the
aggregate-any_value
branch
from
750b950
to
3cd25c6
Compare
|
@jvanstraten updated the PR. Is it okay now? |
jvanstraten
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
any_valueaggregate function.