Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add string_agg aggregate function #297

Merged
merged 3 commits into from
Sep 5, 2022
Merged

feat: add string_agg aggregate function #297

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9056da8
feat(string_agg): initial commit
vibhatha Aug 23, 2022
9a56476
fix(type): replaced varchar with string
vibhatha Aug 26, 2022
8214c20
fix(review): added constant field
vibhatha Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions extensions/functions_string.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,3 +1263,19 @@ scalar_functions:
- value: i32
name: "count"
return: "string"

aggregate_functions:

-
name: string_agg
jvanstraten marked this conversation as resolved.
Show resolved Hide resolved
description: Concatenates a column of string values with a separator.
impls:
- args:
- value: "string"
name: "input"
description: "Column of string values."
- value: "string"
name: "separator"
constant: true
description: "Separator for concatenated strings"
return: "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, and not sure why none of the linters are complaining about this, but there should probably be a newline at the end of the file.