-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove not function that expects two arguments #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Here's an example from ibis: ibis-project/ibis@3f48cb8. The commit message is:
|
@jacques-n How do you want to proceed here? |
Isn't the commit message still missing the breaking change notice? Frankly, I don't think anyone is depending on this change so I'm not stuck on calling it a breaking change other than for rigor. |
BREAKING CHANGE: use the unary `not` function to return the compliment of input argument
c62c149
to
ffff8e7
Compare
I have updated the commit message to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message looks correct to me now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant to block accidental merging until #210 is merged :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #210 is merged, merging this.
avoid introducing unnecessary indirect dependencies Co-authored-by: Victor Barua <victor.barua@datadoghq.com>
This PR removes the
not
function infunctions_boolean.yaml
that expects two boolean arguments.