Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take over maintenance/accept donation of DuckDB substrait-extension #731

Closed
jacques-n opened this issue Nov 5, 2024 · 12 comments
Closed

Comments

@jacques-n
Copy link
Contributor

I believe that there will be little development moving forward on Duckdb Substrait extension as a duckdb core extension. There have been no commits for a couple of months and the home page is fairly cool on accepting contributions "We do not have the capacity to engage with issues or pull requests from external contributors at present".

Myself and a few others have started enhancing the extension in a separate repo. However, we'd like to avoid having multiple active forks. I reached out to the DuckDB team to see if they would potentially be open to moving the main repo to the Substrait project so that we can continue it's development and growth. They've initially been receptive to this idea. I wanted to open discussion here to see whether others in the Substrait community are equally supportive of including accepting. Would love feedback from @substrait-io/smc as well as anyone else in the community. For example, I think @drin has also been working on this extension.

@drin
Copy link
Member

drin commented Nov 5, 2024

Assuming the goal is to expand the number of users that can review and merge PRs by having the "primary" home be under substrait, then that seems reasonable to me.

@hannes
Copy link
Contributor

hannes commented Nov 5, 2024

DuckDB maintainer here, we are indeed happy with the idea of the substrait extension moving here.

@westonpace
Copy link
Member

+1

Given the duckdb team is fine with transferring maintenance and you are comfortable with accepting maintenance I am having a hard time seeing any downsides. There may be some hiccups / compatibility differences between the two as people switch but long term compatibility between the projects seems well worth it. Thank you @jacques-n for taking this effort on.

@mbwhite
Copy link

mbwhite commented Nov 5, 2024

+1 here; several months back I think I found a few things that needed tweaking.

@vbarua
Copy link
Member

vbarua commented Nov 5, 2024

+1 from me as well. Would we want to set it up as a core repo, or a contrib repo?

@jacques-n
Copy link
Contributor Author

Would we want to set it up as a core repo, or a contrib repo?

Either seems fine. I'm slightly inclined to go with non-contrib repo since the main challenge contrib is solving is ensuring access for non-substrait committers. I think at least four people who will be contributing are already committers so using contrib is probably less needed.

@drin
Copy link
Member

drin commented Nov 5, 2024

the main challenge contrib is solving is ensuring access for non-substrait committers

Technical reason aside, I think it'd also be a bit weird to request to take ownership but then to call it a "contrib", so my preference would also be a core/standard repo

@jacques-n
Copy link
Contributor Author

Seems like we have some positive energy here and 3 +1s from SMC (@westonpace , @vbarua , myself). Will leave open for another day or two for additional feedback before concluding. Would love feedback @EpsilonPrime and @cpcloud .

@EpsilonPrime
Copy link
Member

EpsilonPrime commented Nov 6, 2024 via email

@ianmcook
Copy link
Contributor

ianmcook commented Nov 6, 2024

+1 from me. Thank you!

@jacques-n
Copy link
Contributor Author

Seems like all positive here, lets move forward. Will post here as transfer is completed.

@jacques-n
Copy link
Contributor Author

Repo has been moved over. 🎉 Thanks to everyone, especially the DuckDB team and @hannes !

https://github.com/substrait-io/duckdb-substrait-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants