fix(naming): add missing arg names in functions_aggregate_*.yaml (#316)

substrait-io · Sep 14, 2022 · fb92997 · fb92997
1 parent 521b63d
commit fb92997
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/extensions/functions_aggregate_approx.yaml b/extensions/functions_aggregate_approx.yaml
@@ -10,7 +10,8 @@ aggregate_functions:
       result.
     impls:
       - args:
-          - value: any
+          - name: x
+            value: any
         nullability: DECLARED_OUTPUT
         decomposable: MANY
         intermediate: binary

diff --git a/extensions/functions_aggregate_generic.yaml b/extensions/functions_aggregate_generic.yaml
@@ -5,9 +5,11 @@ aggregate_functions:
     description: Count a set of values
     impls:
       - args:
-          - options: [SILENT, SATURATE, ERROR]
+          - name: overflow
+            options: [SILENT, SATURATE, ERROR]
             required: false
-          - value: any
+          - name: x
+            value: any
         nullability: DECLARED_OUTPUT
         decomposable: MANY
         intermediate: i64
@@ -16,7 +18,8 @@ aggregate_functions:
     description: "Count a set of records (not field referenced)"
     impls:
       - args:
-          - options: [SILENT, SATURATE, ERROR]
+          - name: overflow
+            options: [SILENT, SATURATE, ERROR]
             required: false
         nullability: DECLARED_OUTPUT
         decomposable: MANY