Add Initial Extension Support #395
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Begins addressing #367 and #342 by adding support for parsing the types in YAML Simple Extension Files into Rustic types - with validation and validity enforced. This includes a string text parser, handling built-in types, compound types, named structs, custom types, and validated parameter constraints in the Simple Extension YAML files.
ExtensionFile
to load and validate extension YAML and a reusableRegistry
for URI+name type lookup.This is a draft PR - it's mostly ready, but I wanted to do a last couple checks before opening it up too much.
Scope
ExtensionFile
,Registry
,CustomType
,ConcreteType
) and enforces validation of those on creation / read.Key Changes
BuiltinType
,CompoundType
,ConcreteType
,CustomType
with Display/round‑trip support for alias and named‑struct structures.TryFrom<TypeParamDefsItem>
,Parse<RawType>
)ProtoContext
fromContext
, to distinguish between things needed for Protobuf parsing (ProtoContext
)u!Name
) and type variables; visits extension references for linkage bookkeeping.parse
feature includesserde_yaml
;include!(extensions.in)
is gated behindextensions
feature.actions/checkout
to v4, updates Cargo dependency set, and bumps thesubstrait
submodule.Compatibility Notes
ProtoContext
on proto parsing that previously required onlyContext
.extensions.in
now compiled only withfeatures=["extensions"]
.Testing
features=["extensions"]
.