feat(isthumus): extract isthmus CLI into isthmus-cli project #248 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bestbeforetoday
force-pushed
the
isthmus-cli
branch
from
2abc3e0 to
3e40c36
Compare
|
Reverted change to .editorconfig (despite helping me to get correct formatting locally) as the change applied to all files and so fails indentation checks for some file types. |
|
Once #244 is merged, I will rebase on that change and mark this PR for review. |
This avoid transitive dependencies on graal-sdk and picocli components for projects that consume isthmus as a library.
bestbeforetoday
force-pushed
the
isthmus-cli
branch
from
3e40c36 to
98a2457
Compare
bestbeforetoday
changed the title
vbarua
approved these changes
May 2, 2024
|
|
||
| dependencies { | ||
| implementation(project(":core")) | ||
| implementation("org.apache.calcite:calcite-core:${CALCITE_VERSION}") | ||
| implementation("org.apache.calcite:calcite-server:${CALCITE_VERSION}") | ||
| implementation("org.junit.jupiter:junit-jupiter:${JUNIT_VERSION}") | ||
| testImplementation("org.junit.jupiter:junit-jupiter:${JUNIT_VERSION}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid transitive dependencies on graal-sdk and picocli components for projects that consume isthmus as a library.