ci: update github actions #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
commented
Dec 18, 2023
| @@ -78,18 +78,18 @@ jobs: | |||
| run: | | |||
| value=`mv isthmus/build/graal/isthmus isthmus/build/graal/isthmus-${{ matrix.os }}` | |||
| - name: Publish artifact | |||
| uses: actions/upload-artifact@master | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
I suspect that this is what was causing the release failure. All of the download actions are @v3, but the upload action is @master. The upload-artifact action had a 4.0 release recently, and I suspect the @v3 version of download-artifact can't handle the v4 uploads.
|
LGTM! |
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
* ci: upgrade to checkout@v4 * ci: upgrade to upload and download artifact @v4 * ci: upgrade to setup-node@v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.