feat: exhaustive copy on write visitors #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: RelCopyOnWriteVisitor now extends RelVisitor
EpsilonPrime
approved these changes
Nov 7, 2023
core/src/main/java/io/substrait/relation/ExprCopyOnWriteVisitor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/substrait/relation/RelCopyOnWriteVisitor.java
Outdated
Show resolved
Hide resolved
vbarua
force-pushed
the
vbarua/copy-on-write-updates
branch
from
db95285 to
ba112ff
Compare
|
These changes introduce a new public ExpressionCopyOnWriteVisitor class and switch the RelCopyOnWriteVisitor over to use the RelVisitor (instead of AbstractRelVisitor) to force the implementation of all visit methods. The purpose of this is to ensure a complete visitation over relations and expressions in order to enable relation rewrites THROUGH subqueries in expressions. |
core/src/main/java/io/substrait/relation/CopyOnWriteVisitor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/substrait/relation/CopyOnWriteVisitor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/substrait/relation/CopyOnWriteVisitor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/substrait/relation/ExpressionCopyOnWriteVisitor.java
Show resolved
Hide resolved
patientstreetlight
approved these changes
Nov 7, 2023
thanks Victor!
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
BREAKING CHANGE: RelCopyOnWriteVisitor now extends RelVisitor and has generic type parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: RelCopyOnWriteVisitor now extends RelVisitor and has generic type parameter