fix: map switch expression to a Calcite CASE statement #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlyeks
force-pushed
the
switch-expression
branch
from
bd5e22c to
e3bde43
Compare
EpsilonPrime
approved these changes
Oct 19, 2023
vbarua
reviewed
Oct 26, 2023
isthmus/src/test/java/io/substrait/isthmus/SubstraitRelNodeConverterTest.java
Outdated
Show resolved
Hide resolved
vbarua
reviewed
Oct 26, 2023
isthmus/src/test/java/io/substrait/isthmus/ExpressionConvertabilityTest.java
Outdated
Show resolved
Hide resolved
vbarua
reviewed
Oct 26, 2023
vbarua
force-pushed
the
switch-expression
branch
from
e3bde43 to
8480f07
Compare
vbarua
reviewed
Nov 3, 2023
| b.ifClause(b.equal(b.fieldReference(commonTable, 0), b.i32(10)), b.i32(2))), | ||
| b.i32(3)), | ||
| expression); | ||
| } |
There was a problem hiding this comment.
These tests were creating a full plan and converting it, but we only actually want/need to verify the expression conversion.
Removed the plan related noise by converting the expression directly. Also used a bunch of our nice utils (including one I added) to make the tests more readable.
vbarua
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch expression POJO in substrait-java doesn't contain the match expression, so I've updated the definition to include that.
To map into Calcite, I construct a CASE statement. This ends up being translated into an IfThen expression when round-tripping Substrait into Calcite.