Skip to content

Conversation

@Integral
Copy link
Member

@Integral Integral commented Aug 6, 2018

We want to use workflows inside a manuscript editor. This comes with a few examples: add new reference and editing refs using workflows.

Note: This is just the first iteration. We want to merge it and improve UX later.

@Integral Integral changed the base branch from master to metadata-editor August 6, 2018 11:13
@codecov-io
Copy link

codecov-io commented Aug 6, 2018

Codecov Report

Merging #647 into metadata-editor will increase coverage by 0.1%.
The diff coverage is 30.64%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           metadata-editor     #647     +/-   ##
==================================================
+ Coverage            53.22%   53.33%   +0.1%     
==================================================
  Files                  256      257      +1     
  Lines                 7013     7012      -1     
==================================================
+ Hits                  3733     3740      +7     
+ Misses                3280     3272      -8
Impacted Files Coverage Δ
src/article/shared/FormRowComponent.js 100% <ø> (ø)
src/article/shared/AddReferenceWorkflow.js 5% <ø> (ø)
src/article/shared/ReferencePropertyEditor.js 100% <ø> (ø)
src/article/shared/DOIInputComponent.js 2% <ø> (ø)
src/article/shared/SelectInput.js 41.93% <ø> (ø)
src/article/shared/CardComponent.js 100% <ø> (ø)
src/article/metadata/TranslateableEditor.js 69.23% <ø> (ø) ⬆️
src/article/shared/TextInput.js 60% <ø> (ø)
src/article/shared/TranslationPropertyEditor.js 100% <ø> (ø)
src/article/metadata/CollectionEditor.js 84.61% <ø> (-1.1%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6bd9a...13bd159. Read the comment docs.

Copy link
Member

@obuchtala obuchtala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far.

import SchemaAwareToggleListCommand from './SchemaAwareToggleListCommand'
import ArticleNavPackage from '../ArticleNavPackage'
// Workflows
import AddReferenceWorkflow from '../metadata/AddReferenceWorkflow'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can move this into '../shared'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i also thought about this...
do we want to introduce shared styles as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I guess

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my (hoperfully soon) merge, we should do a tidy-up. Eliminate dead code and reduce code/CSS redundancy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, meanwhile I will remove dead code from RefListComponent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Integral Integral changed the title WIP: Manuscript workflows Manuscript workflows Aug 6, 2018
@Integral Integral merged commit 720ff83 into metadata-editor Aug 6, 2018
@Integral Integral deleted the manuscript-workflows branch August 6, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants