-
Notifications
You must be signed in to change notification settings - Fork 85
Manuscript workflows #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manuscript workflows #647
Conversation
Codecov Report
@@ Coverage Diff @@
## metadata-editor #647 +/- ##
==================================================
+ Coverage 53.22% 53.33% +0.1%
==================================================
Files 256 257 +1
Lines 7013 7012 -1
==================================================
+ Hits 3733 3740 +7
+ Misses 3280 3272 -8
Continue to review full report at Codecov.
|
obuchtala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far.
src/article/editor/EditorPackage.js
Outdated
| import SchemaAwareToggleListCommand from './SchemaAwareToggleListCommand' | ||
| import ArticleNavPackage from '../ArticleNavPackage' | ||
| // Workflows | ||
| import AddReferenceWorkflow from '../metadata/AddReferenceWorkflow' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can move this into '../shared'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i also thought about this...
do we want to introduce shared styles as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my (hoperfully soon) merge, we should do a tidy-up. Eliminate dead code and reduce code/CSS redundancy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, meanwhile I will remove dead code from RefListComponent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We want to use workflows inside a manuscript editor. This comes with a few examples: add new reference and editing refs using workflows.
Note: This is just the first iteration. We want to merge it and improve UX later.