Remove article flag #3581
Merged
Remove article flag #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhkawano
requested review from
ChrisAntaki,
jpettitt,
justinchou-google,
oyj9109 and
Wayne-X
as code owners
Comment on lines
945
to
+946
| entitlements: { | ||
| products: ['pub1:label1'], | ||
| subscriptionToken: 's1', | ||
| entitlements: { |
There was a problem hiding this comment.
is this expected? a nested entitlements object?
There was a problem hiding this comment.
Yeah entitlements are contained in the article(which is replacing the old entitlements object), and entitlements object contains an entitlements field itself, which cause this nesting.
https://github.com/subscriptions-project/swg-js/blob/main/src/runtime/entitlements-manager.ts#L77
https://github.com/subscriptions-project/swg-js/blob/main/src/api/entitlements.ts#L40
justinchou-google
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is always set for both basic and the normal runtime, so removing the flag and updating the tests.
b/279927284