Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage in src/runtime/event-type-mapping.ts #3301

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Improve coverage in src/runtime/event-type-mapping.ts #3301

merged 2 commits into from
Nov 10, 2023

Conversation

ChrisAntaki
Copy link
Collaborator

@ChrisAntaki ChrisAntaki commented Nov 10, 2023 •
edited
Loading

  • Adds test covering falsy event arg

@ChrisAntaki ChrisAntaki changed the title Improve coverage of analyticsEventToGoogleAnalyticsEvent function Improve coverage in src/runtime/event-type-mapping-test.js Nov 10, 2023
@ChrisAntaki ChrisAntaki changed the title Improve coverage in src/runtime/event-type-mapping-test.js Improve coverage in src/runtime/event-type-mapping.ts Nov 10, 2023
@ChrisAntaki ChrisAntaki enabled auto-merge (squash) November 10, 2023 19:14
@ChrisAntaki ChrisAntaki merged commit 133599c into subscriptions-project:main Nov 10, 2023
5 checks passed
@ChrisAntaki ChrisAntaki deleted the coverage branch November 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchou-google justinchou-google justinchou-google approved these changes

@jpettitt jpettitt Awaiting requested review from jpettitt jpettitt is a code owner

@oyj9109 oyj9109 Awaiting requested review from oyj9109 oyj9109 is a code owner

@Wayne-X Wayne-X Awaiting requested review from Wayne-X Wayne-X is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisAntaki @justinchou-google