Start buy flow if loading for rewarded ads fails #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js into rewarded_ad_handle_failure
mhkawano
requested review from
ChrisAntaki,
fikus,
jpettitt,
justinchou-google,
oyj9109 and
Wayne-X
as code owners
fikus
approved these changes
Oct 16, 2023
Comment on lines
347
to
349
| if (this.params_.onCancel) { | ||
| this.params_.onCancel(); | ||
| } |
There was a problem hiding this comment.
nit: replace with this.params_.onCancel?.();
Comment on lines
351
to
353
| if (this.params_.monetizationFunction) { | ||
| this.params_.monetizationFunction(); | ||
| } |
There was a problem hiding this comment.
Similar here, use optional chaining to invoke the function.
| @@ -292,7 +292,7 @@ const REWARDED_AD_CSS = css` | |||
| color: #202124; | |||
| grid-column: 2; | |||
| grid-row: 1; | |||
| line-break: anywhere; | |||
| line-break: auto; | |||
There was a problem hiding this comment.
Is this unrelated changed meant to be included?
|
Applied the changed and updated the description with a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where we cannot init gpt.js we will mark rewarded ads as dismissed and show a buy flow.
b/305721069