Repository navigation
Reject ambiguous and empty retrieval evidence - #2
Merged
Merged
Conversation
suboss87
marked this pull request as ready for review
September 29, 2026 06:42
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reproduced on main15d6607: duplicate authorized_doc_ids JSON fields silently chose the last permission set and produced PASS. Direct evaluate([]) also produced PASS.
Change
Reject duplicate JSON fields with line diagnostics; reject empty/duplicate direct API batches and nonobject cases. Preserve valid iterators and evaluation metrics. Include intentionally invalid fixture and reproduction notes.
Verification
12 unittest tests pass, including both CLI formats returning exit2 and no report for ambiguous permission evidence. Existing clean/regression and stale/corrected SQLite paths remain covered. git diff --check passes.
Scope
Honcho source-oracle integration deferred after bounded source inspection: filtered exact search does not establish independent permission truth. No deployment, novelty, or adoption claim. Parent reviewer will separately inspect this exact commit before any merge.