Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Flannel CNI Discovery to List DaemonSets Across All Namespaces #3210

Closed
aswinayyolath opened this issue Nov 4, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@aswinayyolath
Copy link

What would you like to be added:
I would like to request an enhancement to the Flannel CNI discovery logic to list DaemonSets in all namespaces and filter them by the k8s-app=flannel label.

Why is this needed:
The current Flannel discovery implementation may not capture all Flannel instances if they are deployed in different namespaces. By updating the discovery code to search across all namespaces, we can ensure that all Flannel DaemonSets are recognized and accounted for, improving network connectivity and resource management in multi-namespace Kubernetes environments. This change would enhance the reliability of the Flannel network configuration and make it easier to manage Flannel deployments.

@aswinayyolath aswinayyolath added the enhancement New feature or request label Nov 4, 2024
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 4, 2024
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 5, 2024
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 5, 2024
@aswinayyolath
Copy link
Author

I was able to to build the binary with this changes as per the instructions provided here. Tried running deploy-broker , join commands using cmd/bin/subctl and that worked fine. All unit tests are passing as well

aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 10, 2024
- Simplified the label matching logic in the Flannel discovery to use `controllerClient.MatchingLabels`.
- Updated Canal discovery to pass `metav1.NamespaceSystem` directly to `extractCIDRsFromFlannelConfigMap`, eliminating the need to extract the namespace from the first DaemonSet.

Contributes to: submariner-io/submariner#3210

Signed-off-by: Aswin A <aswin6303@gmail.com>
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 11, 2024
…e a generic plugin is returned.

Contributes to: submariner-io/submariner#3210

Signed-off-by: Aswin A <aswin6303@gmail.com>
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 11, 2024
Simplified the label matching logic in the Flannel discovery

Contributes to: submariner-io/submariner#3210

Signed-off-by: Aswin A <aswin6303@gmail.com>
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 11, 2024
aswinayyolath added a commit to aswinayyolath/submariner-operator that referenced this issue Nov 11, 2024
fixed go lint issues

Contributes to: submariner-io/submariner#3210

Signed-off-by: Aswin A <aswin6303@gmail.com>
tpantelis pushed a commit to aswinayyolath/submariner-operator that referenced this issue Nov 11, 2024
tpantelis pushed a commit to submariner-io/submariner-operator that referenced this issue Nov 11, 2024
@aswinayyolath
Copy link
Author

Closing this issue as completed!

aswinayyolath added a commit to aswinayyolath/submariner-website that referenced this issue Nov 13, 2024
Contributes to: submariner-io/submariner#3210

Signed-off-by: Aswin A <aswin6303@gmail.com>
tpantelis pushed a commit to submariner-io/submariner-website that referenced this issue Nov 13, 2024
Contributes to: submariner-io/submariner#3210

Signed-off-by: Aswin A <aswin6303@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant