Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for upgrades between all supported minor versions #2369

Open
dfarrell07 opened this issue Mar 30, 2023 · 5 comments
Open

Add CI for upgrades between all supported minor versions #2369

dfarrell07 opened this issue Mar 30, 2023 · 5 comments

Comments

@dfarrell07
Copy link
Member

What would you like to be added:

Add CI to test upgrades from 0.12.x to 0.13.y to 0.14.z to devel. There are a number of different ways this could be built for slightly different coverage.

  • 0.x.0 to 0.y.0
  • 0.x.latest to 0.y.latest
  • 0.x.0...latest to 0.y.0...latest (every release from the first release of 0.x to the latest of 0.y)

This should likely be a periodic job, to supplement the 0.x.latest to 0.x.devel jobs currently run on PRs.

Why is this needed:

While writing docs about upgrades for submariner-io/submariner-website#625, it became clear we don't test many upgrades users are likely to actually do.

@dfarrell07 dfarrell07 self-assigned this Mar 30, 2023
dfarrell07 added a commit to dfarrell07/get.submariner.io that referenced this issue May 1, 2023
This could be used to enable additional upgrade testing without having
to maintain a hard-coded tracker for the last release in CI.

It could also replace our current use of the `latest` target in CI, to
allow fixes to release branches to fix upgrade CI without having to
disable upgrade jobs. Example of needing this:

submariner-io/lighthouse#736 (comment)

Fixes: submariner-io#23
Relates-to: submariner-io/submariner#2369
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
dfarrell07 added a commit to dfarrell07/get.submariner.io that referenced this issue May 1, 2023
This could be used to enable additional upgrade testing without having
to maintain a hard-coded tracker for the last release in CI.

It could also replace our current use of the `latest` target in CI, to
allow fixes to release branches to fix upgrade CI without having to
disable upgrade jobs. Example of needing this:

submariner-io/lighthouse#736 (comment)

Fixes: submariner-io#23
Relates-to: submariner-io/submariner#2369
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
@dfarrell07
Copy link
Member Author

submariner-io/get.submariner.io#23 will be helpful, but it would also be nice if we could somehow leverage the API URL sort order trick and subtract 1 or 2 from the version to enable other upgrade tests without maintaining versions in CI.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2023
@dfarrell07 dfarrell07 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2023
@dfarrell07
Copy link
Member Author

dfarrell07 commented Nov 30, 2023

We might be able to use PR's target branch as a signal to know which versions to test dynamically.

If we do a full git checkout we'll also have the tags, which is another signal.

We'll still likely need submariner-io/get.submariner.io#44.

@dfarrell07 dfarrell07 reopened this Nov 30, 2023
@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Dec 5, 2023
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 8, 2024
@dfarrell07 dfarrell07 removed the stale label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants