E2E: use ServiceDiscovery CR to determine if clusterset IP is enabled

[vthapar]

...in E2E tests coz lighthouse agent may not be present if service-discovery is disabled.

[submariner-bot]

🤖 Created branch: z_pr1653/vthapar/clustersetip-e2e-fix
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

[tpantelis]

If only SD is installed than the Submariner CR isn't created so I think we should look for the ServiceDiscovery CR. Of course if SD isn't installed then that CR won't exist. So we can either Get the ServiceDiscovery CR without using use AwaitUntil and set ClusterSetIPEnabled = if ServiceDiscovery found && ServiceDiscovery.Spec.ClusterSetIPEnabled OR, preferably, lazily do this check from BeforeEach:

    var clusterSetIPEnabled = atomic.Pointer[bool]{}
    ...
    func IsClusterSetIPEnabled() bool {
	enabledPtr := clusterSetIPEnabled.Load()
	if enabledPtr != nil {
		return *enabledPtr
	}

	gvr, _ := schema.ParseResourceArg("servicediscoveries.v1alpha1.submariner.io")
	sdClient := framework.DynClients[0].Resource(*gvr).Namespace(framework.TestContext.SubmarinerNamespace)

	framework.AwaitUntil("find service-discovery resource", func() (interface{}, error) {
		return sdClient.Get(context.TODO(), "service-discovery", metav1.GetOptions{})
	}, func(result interface{}) (bool, string, error) {
		enabled, _, err := unstructured.NestedBool(result.(*unstructured.Unstructured).Object, "spec", "clustersetIPEnabled")
		if err != nil {
			return false, "", err
		}

		clusterSetIPEnabled.Store(ptr.To(enabled))

		return true, "", nil
	})

	return *clusterSetIPEnabled.Load()
    }

[tpantelis]

I pushed this change.

[vthapar]

set ClusterSetIPEnabled = if ServiceDiscovery found && ServiceDiscovery.Spec.ClusterSetIPEnabled

This works better.

[vthapar]

looks good, but I can't approve the review.

[submariner-bot]

🤖 Closed branches: [z_pr1653/vthapar/clustersetip-e2e-fix]