Adjust to generic resource changes in Admiral #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
aswinsuryan,
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1402/skitt/generic-resource |
skitt
force-pushed
the
generic-resource
branch
from
f36d8c5
to
32037a5
Compare
|
This PR/issue depends on:
|
tpantelis
approved these changes
Oct 10, 2023
Lighthouse only uses the dynamic client, so this only adds the appropriate [runtime.Object] type parameters. Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt
force-pushed
the
generic-resource
branch
from
32037a5
to
683bfc6
Compare
sridhargaddam
approved these changes
Oct 10, 2023
|
🤖 Closed branches: [z_pr1402/skitt/generic-resource] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse only uses the dynamic client, so this only adds the appropriate [runtime.Object] type parameters.
Depends on submariner-io/admiral#756