Add list resources by label selector method to syncer interfaces #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr684/tpantelis/list_by_selector |
skitt
approved these changes
Jul 19, 2023
It's useful for users to query resources by selector filter rather than list all resources and filter afterwards. The new method does not return an error, as ListResources does, to simplify usage. There are 2 error cases, neither of which is recoverable by the caller: - cache.WaitForCacheSync returns false. This means the informer was stopped so log a warning and return an empty list. - conversion from Unstructured to the resource type which is a programming error and shouldn't happen so use r.convertNoError. In fact, we really should just panic but that can be done in a separate PR. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
dfarrell07
approved these changes
Jul 19, 2023
| } | ||
|
|
||
| Expect(actual).To(HaveLen(len(expSpecs))) | ||
| for _, obj := range actual { |
There was a problem hiding this comment.
pkg/syncer/resource_syncer_test.go:972:2: ranges should only be cuddled with assignments used in the iteration (wsl)
for _, obj := range actual {
^
https://github.com/submariner-io/admiral/actions/runs/5600444498/jobs/10242837481?pr=684
The internal implementation of ListResources can no longer return an error so modify the signature accordingly to simplify usage. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
force-pushed
the
list_by_selector
branch
from
9b69b4c
to
7b545b1
Compare
yeah my regular laptop is being repaired so I'm using my RH laptop and things aren't fully setup. |
|
@skitt @dfarrell07 I made some further changes which seems to have crossed with your reviews. Basically I removed error from the ListResources* methods to simplify usage. |
skitt
approved these changes
Jul 20, 2023
|
🤖 Closed branches: [z_pr684/tpantelis/list_by_selector] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful for users to query resources by selector filter rather than list all resources and filter afterwards.
The new method does not return an error, as
ListResourcesdoes, to simplify usage. There are 2 error cases, neither of which is recoverable by the caller:cache.WaitForCacheSyncreturns false. This means the informer was stopped so log a warning and return an empty list.Unstructuredto the resource type failed which is a programming error and shouldn't happen so user.convertNoError. In fact, we really should just panic but that can be done in a separate PR.The new method is called by
ListResourceswhich now can no longer return an error so error was removed from the return signature.