Add LSP-rustowl

[CREAsTIVE]

https://github.com/CREAsTIVE/LSP-rustowl

[CREAsTIVE]

any updates?

[jwortmann]

The PR reviewer action is currently broken -> #128

I took a quick look over the plugin and I would recommend to create an LspTextCommand to run the server request. Within that command you can use self.session_by_name to retrieve the plugin's session (instead of needing to use the "private" LSP methods to get the session from the listener). Then you would just run this command from your EventListener callbacks. That would also give you the flexibility to manually run this command from a key binding or context menu, in case that might be useful.

For example:

from LSP.plugin import LspTextCommand
from LSP.plugin.core.registry import get_position

class LspRustowlAnalyzeCommand(LspTextCommand):
    session_name = SESSION_NAME

    def run(self, edit: sublime.Edit, event: dict | None = None, point: int | None = None) -> None:
        session = self.session_by_name(self.session_name)
        if session:
            pos = position(self.view, get_position(self.view, event, point))
            session.send_request(...)

class Listener(sublime_plugin.EventListener):
    def on_selection_modified(self, view: sublime.View):
        if get_setting(view, "rustowl.hover_type") == "cursor" and len(view.sel()) > 0:
            view.run_command("lsp_rustowl_analyze", {"point": view.sel()[0].a})

    def on_hover(self, view, point, hover_zone):
        if get_setting(view, "rustowl.hover_type") == "mouse":
            view.run_command("lsp_rustowl_analyze", {"point": point})

[CREAsTIVE]

Repository was updated, new version published. Now its possible to use lsp-rustowl with commands only, without auto analyzing selected token, thanks @jwortmann. I will wait for reviewer action tool to be fixed.

[CREAsTIVE]

bump

[CREAsTIVE]

bump x2

[CREAsTIVE]

bububump?

[rwols]

Apologies for the silence. I'm looking at your plugin.

[rwols]

@CREAsTIVE could you please rebase to the latest main branch changes? (I think #128 makes the PR bot work)

[rwols]

LGTM in any case

[STReviewBot]

Automated testing result: WARNING

Repo link: LSP-rustowl
Results help

Packages added:
  - LSP-rustowl

Processing package "LSP-rustowl"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 50, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 52, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 54, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 60, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 62, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 64, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 69, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 155, Column: 8

[STReviewBot]

Automated testing result: WARNING

Repo link: LSP-rustowl
Results help

Packages added:
  - LSP-rustowl

Processing package "LSP-rustowl"
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 50, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 52, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 54, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 60, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 62, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 64, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 69, Column: 8
  - WARNING: It looks like you're using platform-dependent code. Make sure you thought about the platform key in your pull request.
    - File: plugin.py
    - Line: 155, Column: 8

[CREAsTIVE]

@CREAsTIVE could you please rebase to the latest main branch changes? (I think #128 makes the PR bot work)

Done, thanks for response :D

[rwols]

Did you verify your plug-in works on macOS, Linux and Windows?

[CREAsTIVE]

Did you verify your plug-in works on macOS, Linux and Windows?

I did verify it on windows, forget about other platforms, my bad. I will come back when I check the functionality on other platforms