Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SnippetTextEdits #2426

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwortmann
Copy link
Member

Untested, but I think something like this could work

CI will obviously fail until the protocol types are updated to the latest spec version.

This would probably make 2910042 obsolete at some point in the future, assuming that rust-analyzer switches from its custom SnippetTextEdit to the one from the LSP 3.18 specs.

@rchl
Copy link
Member

rchl commented Sep 22, 2024

We have SnippetTextEdit type now.

@jwortmann
Copy link
Member Author

I think I will probably revisit this PR when there is a server which supports the SnippetTextEdit, so that it can be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants