Skip to content

Conversation

@rchl
Copy link
Member

@rchl rchl commented Aug 26, 2021

I think I don't need to include source.js.react since it should be matched by source.js but haven't verified that.

Fixes #60

Copy link
Member

@rwols rwols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say drop the ST3 compatibility :D but you do you.

@rchl
Copy link
Member Author

rchl commented Aug 27, 2021

I'm having doubts about this change now...

I imagine that there is a group of people who are using the flow (source.js.flow) syntax for all *.js files (since it shouldn't break anything for plain JS files) and just disable LSP-typescript in flow-only projects. With this change that flow would break as the server would no longer work in non-flow projects...

I say drop the ST3 compatibility :D but you do you.

I'm not dropping ST3 compat unless there is a good reason for it. :)
And then I'd fork a tag for ST3 to not break it but just leave unmaintained.

@alecmev
Copy link
Contributor

alecmev commented Aug 27, 2021

My situation is certainly exotic, so I'm happy either way, but a quick google search shows that "source.js.flow" doesn't really exist in the wild. As an example, Naomi marks it as source.flow instead.

@rchl rchl changed the title Exclude flow from the scope Explicitly define ST4 selector Aug 28, 2021
@rchl
Copy link
Member Author

rchl commented Aug 28, 2021

To avoid potentially breaking change, decided to not exclude flow. Only defined the selector to make it more obvious for people wanting to change it.

How to handle "flow" better should instead go to the readme. You are welcome to submit a PR for it @alecmev

@rchl rchl merged commit d4f506d into master Aug 28, 2021
@rchl rchl deleted the fix/flow-selector branch August 28, 2021 19:31
@alecmev alecmev mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Flow in React Project. Type annotations can only be used in TypeScript files error.

4 participants