Skip to content

Conversation

michaelblyons
Copy link
Collaborator

@michaelblyons michaelblyons commented Feb 13, 2025

Additions:

  • add tests for applescript scopes
  • add more granular sub-scopes
  • add completions for applications from ScriptEditor
  • add completions for standard library from ScriptEditor

Changes:

References:

@jrappen
Copy link
Collaborator

jrappen commented Feb 13, 2025

Thanks for working on this.

I still have some left-overs from rainy days from autumn with what I started with while going through this package. Should I send you a zip via Discord?

@michaelblyons michaelblyons marked this pull request as draft February 14, 2025 17:18
@michaelblyons
Copy link
Collaborator Author

Okay, now I'm doing more work on it.

@jrappen
Copy link
Collaborator

jrappen commented Mar 24, 2025

  • If you use pop: 1 in the added lines, you should bump to v2 and replace remaining pop: true from unchanged lines. If tests fail, there's a list of differences between v1 and v2 at https://www.sublimetext.com/docs/syntax.html#compatibility, but you knew that.
  • Were you going to add some of the completions I sent you? Some of the files are empty, and the ones that can be used might need a fix in trigger to remove spaces where there are some. But I tried to add as much to details as I could find from the offical docs, so that might be helpful. I can do it myself in a later PR too, whatever works for you.

Otherwise LGTM.

jrappen added 2 commits April 20, 2025 03:20
- fix eol-pop var
- move comments to top
- add `meta_include_prototype: false` to comment and string body
- use syntax var for leading whitespace
- use syntax var for lookahead at eol with optional comment
@jrappen jrappen requested review from jrappen and deathaxe May 19, 2025 13:39
jrappen
jrappen previously approved these changes May 19, 2025
Copy link
Collaborator

@deathaxe deathaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say too much about AppleScript itself, but syntax LGTM!

@jrappen jrappen merged commit cf5cf85 into sublimehq:master May 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants