-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Markdown] list items in blockquotes detected as indented codeblocks #2942
Labels
T: bug
A bug in an existing language feature
Comments
deathaxe
added a commit
to deathaxe/sublime-packages
that referenced
this issue
Jan 23, 2022
Fixes sublimehq#2942 Fixes sublimehq#3170 This commit proposes to apply refactored Markdown syntax from MarkdownEditing 3.1.1, which was originally been based on ST's default Markdown syntax. This commit fixes various compatibility issues with CommonMark and adds all related test cases of value to prove compliance from https://spec.commonmark.org/0.30/spec.json. Main changes are: * fix regression with latex block highlighting in list items * fix CommonMark compatibility of backslash escapes * fix CommonMark compatibility of block quotes * fix CommonMark compatibility of html entities * fix CommonMark compatibility of fenced code blocks * fix CommonMark compatibility of indented code blocks (mixed tabs/spaces) * fix CommonMark compatibility of reference definitions * fix CommonMark compatibility of thematic breaks * update strikethough markup to use 2 tildes It does not yet introduce branching to a broader extend in order to limit changes to the syntax test file. Those are planned for future PRs after being developed and tested in MarkdownEditing repo. Note: 1. All 3rd-party syntaxes or extensions have been removed. 2. For details about single changes, please follow MarkdownEditing's commit history. All syntax related commits start with "Syntax: ".
deathaxe
added a commit
that referenced
this issue
May 7, 2022
[Markdown] Refactor Syntax Fixes #1930 Fixes #2542 Fixes #2857 Fixes #2942 Fixes #3073 Addresses #3154 (in ST3 compatible way) Fixes #3157 Fixes #3170 Addresses #3228 This commit refactors Markdown syntax to 1. improve compliance with CommonMark specification: https://spec.commonmark.org/0.30 Many tests are added to proof compliance: https://spec.commonmark.org/0.30/spec.json Latest GFM syntax is based on CommonMark at the time writing, so those rules are included as well: https://github.github.com/gfm/ 2. convert most anonymous to named contexts for better support of inheritance. 3. reorganize syntax into logical sections for better readability and maintainability. 4. address most Markdown related issues of sublimehq/Packages repo. Main changes are: - fix CommonMark compatibility of backslash escapes - fix CommonMark compatibility of block quotes - fix CommonMark compatibility of html entities - fix CommonMark compatibility of fenced code blocks - fix CommonMark compatibility of indented code blocks (mixed tabs/spaces) - fix CommonMark compatibility of reference definitions - fix CommonMark compatibility of thematic breaks - update strike-through markup to use 2 tildes only - reorganizing contexts in logical sections Benchmarks: This commit has no impact on parsing performance. Notes: 1. Some remaining CommonMark incompatibilities need further work using ST4's "branching" feature. 2. Main refactoring work was done in MarkdownEditing package and released with version 3.1.1. This commit contains the result of that work, except some features which rely on 3rd-party (syntax) packages. Removed features are: - coffee script support in front-matter - numerous code-block syntaxes (E.g.: Ada, Coffee Script, ...) - LaTex blocks - custom `<kbd>` tag highlighting as it doesn't meet quality expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: