Skip to content

Commit

Permalink
yaml file matches with the example text.Merge pull request kubernetes…
Browse files Browse the repository at this point in the history
…-sigs#1334 from mlavacca/conformance-gateway-unexisting-secret

conformance: listener references invalid secret
  • Loading branch information
k8s-ci-robot authored and subi9 committed Aug 19, 2022
2 parents 914a630 + b2a847f commit 38e8d36
Show file tree
Hide file tree
Showing 3 changed files with 80 additions and 0 deletions.
58 changes: 58 additions & 0 deletions conformance/tests/gateway-secret-missing-referenced-secret.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
/*
Copyright 2022 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package tests

import (
"testing"

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"

"sigs.k8s.io/gateway-api/apis/v1alpha2"
"sigs.k8s.io/gateway-api/conformance/utils/kubernetes"
"sigs.k8s.io/gateway-api/conformance/utils/suite"
)

func init() {
ConformanceTests = append(ConformanceTests, GatewaySecretMissingReferencedSecret)
}

var GatewaySecretMissingReferencedSecret = suite.ConformanceTest{
ShortName: "GatewaySecretMissingReferencedSecret",
Description: "A Gateway should fail to become ready if the Gateway has a certificateRef for a nonexistent Secret",
Manifests: []string{"tests/gateway-secret-missing-referenced-secret.yaml"},
Test: func(t *testing.T, s *suite.ConformanceTestSuite) {
gwNN := types.NamespacedName{Name: "gateway-secret-missing-referenced-secret", Namespace: "gateway-conformance-infra"}

t.Run("Gateway listener should have a false ResolvedRefs condition with reason InvalidCertificateRef", func(t *testing.T) {
listeners := []v1alpha2.ListenerStatus{{
Name: v1alpha2.SectionName("https"),
SupportedKinds: []v1alpha2.RouteGroupKind{{
Group: (*v1alpha2.Group)(&v1alpha2.GroupVersion.Group),
Kind: v1alpha2.Kind("HTTPRoute"),
}},
Conditions: []metav1.Condition{{
Type: string(v1alpha2.ListenerConditionResolvedRefs),
Status: metav1.ConditionFalse,
Reason: string(v1alpha2.ListenerReasonInvalidCertificateRef),
}},
}}

kubernetes.GatewayStatusMustHaveListeners(t, s.Client, s.TimeoutConfig, gwNN, listeners)
})
},
}
19 changes: 19 additions & 0 deletions conformance/tests/gateway-secret-missing-referenced-secret.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: Gateway
metadata:
name: gateway-secret-missing-referenced-secret
namespace: gateway-conformance-infra
spec:
gatewayClassName: "{GATEWAY_CLASS_NAME}"
listeners:
- name: https
port: 443
protocol: HTTPS
allowedRoutes:
namespaces:
from: All
tls:
certificateRefs:
- group: ""
kind: Secret
name: nonexistent-secret
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ spec:
- type: URLRewrite
urlRewrite:
hostname: elsewhere.example
path:
type: ReplacePrefixMatch
replacePrefixMatch: /fennel
backendRefs:
- name: example-svc
weight: 1
Expand Down

0 comments on commit 38e8d36

Please sign in to comment.