fix: Join "scope" on google auth #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyanokomiya
force-pushed
the
work/google_auth_scope
branch
from
2ae4084
to
2d9c5f2
Compare
|
Can you please fix the conflicts? I will merge the PR. |
- "RedirectOptions" declares it as "string[]" - It's same as "src/providers/github/redirect.ts"
miyanokomiya
force-pushed
the
work/google_auth_scope
branch
from
2d9c5f2
to
55de670
Compare
|
@subhendukundu Sorry for the late response, I rebuilt it. Thanks! |
| @@ -3,7 +3,7 @@ import { ConfigError } from "../../utils/errors"; | |||
| export default async function redirect({ options, }) { | |||
| const { clientId, redirectUrl, // Deprecated, use redirectTo instead | |||
| redirectTo, // Use this instead of redirectUrl | |||
| scope = "openid email profile", responseType = "code", state = "pass-through value", accessType = "online", } = options; | |||
| scope = ["openid", "email", "profile"], responseType = "code", state = "pass-through value", accessType = "online", } = options; | |||
There was a problem hiding this comment.
If we change this, we would need to change the scope type string to array as well. Also might create a different type then other providers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error when I use multiple scope items.