Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
286 commits
Select commit Hold shift + click to select a range
b12d561
adding diffusivity models for CANTERA
Cristopher-Morales Sep 24, 2024
74b5343
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Sep 24, 2024
51a854b
showing error when INC_NONDIM is INITIAL_VALUES or REFERENCE_VALUES
Cristopher-Morales Sep 27, 2024
e162329
reducing some pointers and arrays needed
Cristopher-Morales Sep 30, 2024
46b4746
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Sep 30, 2024
6ad4e5d
version updated
Cristopher-Morales Sep 30, 2024
a555012
adding unit test case Cantera
Cristopher-Morales Oct 1, 2024
f76cbd8
adding chemical source term to species transport
Cristopher-Morales Oct 4, 2024
dfed203
define DIFFUSIVITY_MODEL=CANTERA , transport model defines the diffus…
Cristopher-Morales Oct 4, 2024
df2ea0c
adding chemical source term
Cristopher-Morales Oct 8, 2024
a361e84
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Oct 8, 2024
e68a17a
adding source terms as outputs
Cristopher-Morales Oct 9, 2024
24ffda2
adding ignition and saving marker inlet composition for future implem…
Cristopher-Morales Oct 9, 2024
368d602
adding gas names to outputs for cantera, adding SetChemical_GasCompos…
Cristopher-Morales Oct 9, 2024
66e67ac
adding species name to flow and adjoint outputs
Cristopher-Morales Oct 16, 2024
f1d661d
adding gas names to SURFACE_SPECIES outputs in history.csv
Cristopher-Morales Oct 16, 2024
9a43e24
small fix init.py
Cristopher-Morales Oct 16, 2024
bdb42ce
adding heat release
Cristopher-Morales Oct 18, 2024
ca9083e
solving for enthalpy
Cristopher-Morales Oct 22, 2024
0487a68
fixing flux jacobian
Cristopher-Morales Oct 25, 2024
dd369bb
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Oct 26, 2024
6fcab1a
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Oct 26, 2024
5076f9d
fix output error
Cristopher-Morales Oct 26, 2024
09fe6f4
adding enthalpy diffusion
Cristopher-Morales Oct 31, 2024
851b13f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Oct 31, 2024
b507934
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Oct 31, 2024
f258308
moving enthalpy diffusion terms to CIncNSSolver.cpp
Cristopher-Morales Nov 3, 2024
63a8f37
small fix
Cristopher-Morales Nov 3, 2024
cb1d3ef
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Nov 4, 2024
f290e08
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Nov 4, 2024
c254983
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Nov 4, 2024
481db68
adding enthalpy and gradient diffusivities
Cristopher-Morales Nov 7, 2024
573cefc
increasing MAXNVAR in scalar convection and diffusion
Cristopher-Morales Nov 8, 2024
30d0b88
cleaning and rewritting some functions
Cristopher-Morales Nov 9, 2024
a8af977
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Nov 9, 2024
e002990
adding heat release as an output
Cristopher-Morales Nov 10, 2024
b4d659d
setting enthalpy, temperature and thermochemical properties for ignit…
Cristopher-Morales Nov 18, 2024
86de2fb
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Nov 18, 2024
dd22fcd
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Nov 18, 2024
59d42d9
updating test case multicomponent cantera
Cristopher-Morales Nov 22, 2024
7f92730
axisymetric source term and corrected flux jacobian at the wall
Cristopher-Morales Nov 22, 2024
dfaa6be
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Nov 22, 2024
e54bdea
adding axisymmetric source term
Cristopher-Morales Nov 26, 2024
cec0868
update BC_ConjugateHeat_Interface for enthalpy equation
Cristopher-Morales Nov 30, 2024
fdbb9b9
updating BC_ConjugateHeat_Interface for fluid mixture
Cristopher-Morales Nov 30, 2024
dc66d0c
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Dec 9, 2024
c0b10a6
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Dec 9, 2024
70bb3d4
setting formation enthalpies and fixing heat release
Cristopher-Morales Dec 16, 2024
911c996
Merge branch 'develop' into feature_preconditioning
Dec 23, 2024
2af10c3
activating muscl, consistent extrapolation for multicomponent
Jan 2, 2025
d0d0221
Merge branch 'develop' into feature_preconditioning
Jan 2, 2025
a1f526c
correct average enthalpy for multicomponent flows output
Jan 10, 2025
15dd3a6
small fix chemical source term
Cristopher-Morales Jan 10, 2025
c469d32
Merge branch 'develop' into feature_preconditioning
Jan 11, 2025
ef2dc5f
changing boolean names
Jan 11, 2025
94bd0b0
up to date to develop
Jan 11, 2025
280a35d
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jan 14, 2025
ea68c00
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jan 14, 2025
1c44044
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jan 14, 2025
912642b
adding brackets
Cristopher-Morales Jan 18, 2025
a6ce2d4
fixing warning
Cristopher-Morales Jan 18, 2025
e9d1e1f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jan 23, 2025
127df29
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jan 25, 2025
211dda0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jan 27, 2025
b47e3de
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jan 28, 2025
d568a9e
updating to develop and preconditioning branch
Cristopher-Morales Jan 28, 2025
058c0ef
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Jan 30, 2025
3793d13
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jan 30, 2025
0655c99
adding standard reference temperature T0=298.15K as default value
Cristopher-Morales Jan 30, 2025
3a2f546
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Jan 30, 2025
a14446c
adding jacobian chemical source term (testing)
Cristopher-Morales Jan 31, 2025
b8b45ef
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Feb 2, 2025
ec1ef48
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Feb 3, 2025
aca6e19
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Feb 13, 2025
2491f26
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Feb 14, 2025
5c656bb
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Feb 16, 2025
9d17cb2
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Feb 17, 2025
3f45e1c
reformulating and cleaning
Cristopher-Morales Feb 18, 2025
b1fc9d4
cleaning flow_diffusion.hpp and .cpp
Cristopher-Morales Feb 19, 2025
b23913a
removing spaces
Cristopher-Morales Feb 21, 2025
b50088d
up-to-date with feature preconditioning
Cristopher-Morales Feb 21, 2025
57d8aab
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Feb 21, 2025
1961b08
fix description working variable
Cristopher-Morales Feb 21, 2025
8dff31b
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Feb 21, 2025
02e5eac
update parallel regresion test
Cristopher-Morales Feb 22, 2025
810d2df
fix non-dimensionalization issue
Cristopher-Morales Feb 22, 2025
4e9f412
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Feb 22, 2025
70ae6ee
updating species Non-Dimensional test case
Cristopher-Morales Feb 22, 2025
89c3e12
cleaning and updating to feature_preconditioning
Cristopher-Morales Feb 24, 2025
e9d3f4c
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 4, 2025
165a9ad
fix parallel_regression.py
Cristopher-Morales Mar 4, 2025
eabaabf
updating regression test cases
Cristopher-Morales Mar 4, 2025
ea01b35
updating to preconditioning
Cristopher-Morales Mar 4, 2025
3a004be
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Mar 4, 2025
053eabd
adding underelaxation factor option
Cristopher-Morales Mar 7, 2025
36566b7
adding lowerlimit for underrelaxation factor
Cristopher-Morales Mar 7, 2025
96c6219
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 8, 2025
e254dbd
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Mar 8, 2025
e1d873b
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 10, 2025
b2efd4a
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Mar 10, 2025
bbb76ae
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 10, 2025
aad36d1
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Mar 11, 2025
52a1689
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 11, 2025
75e3c71
add EPS species transport
Cristopher-Morales Mar 14, 2025
282396a
unable gradient chemical source term
Cristopher-Morales Mar 14, 2025
56f0d86
undo EPS change
Cristopher-Morales Mar 14, 2025
5eec6ad
enable chemical gradient
Cristopher-Morales Mar 14, 2025
8d829b2
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 24, 2025
2711d27
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Mar 24, 2025
1b7bba0
adding mass flux correction continuity equation
Cristopher-Morales Mar 24, 2025
8a6b0f0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 25, 2025
f03f649
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Mar 25, 2025
6a54f9f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 26, 2025
5ce0c57
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Mar 26, 2025
761a3ac
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Mar 28, 2025
72046b0
test source average
Cristopher-Morales Mar 31, 2025
1304b05
undo average source term and retrieving delta time
Cristopher-Morales Apr 1, 2025
1e624d2
test bash reactor
Cristopher-Morales Apr 7, 2025
0da0297
set temperature limit
Cristopher-Morales Apr 8, 2025
fc0419f
recomputation source terms batch reactor
Cristopher-Morales Apr 9, 2025
b429804
small fix
Cristopher-Morales Apr 9, 2025
de7879a
test computing mean integral
Cristopher-Morales Apr 10, 2025
31b6101
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Apr 14, 2025
91757d0
chemical source
Cristopher-Morales Apr 14, 2025
be00947
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Apr 28, 2025
c7ff2bf
updating with develop
Cristopher-Morales Apr 28, 2025
52982a4
updating to develop
Cristopher-Morales Apr 28, 2025
7b27fe7
deleting chemical dictionary
Cristopher-Morales Apr 29, 2025
c12f5f6
test source term
Cristopher-Morales Apr 30, 2025
e537bb2
cleaning
Cristopher-Morales May 1, 2025
ca43883
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales May 7, 2025
f1ddb3c
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales May 12, 2025
d0f5577
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jun 2, 2025
f821c84
adding option time integration
Cristopher-Morales Jun 2, 2025
c6635a9
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jun 2, 2025
4428a03
update parallel regression test
Cristopher-Morales Jun 3, 2025
faa4cdb
adding temperature limits incompressible solver
Cristopher-Morales Jun 3, 2025
395430d
adding adj enthalpy fields for incompressible solver
Cristopher-Morales Jun 4, 2025
247e64b
adding HeatFluxDiffusion in Preaccumulation
Cristopher-Morales Jun 4, 2025
f232ff5
updating to preconditioning branch
Cristopher-Morales Jun 5, 2025
fcacd18
updating JST and Lax-Friedrich
Cristopher-Morales Jun 6, 2025
5e1dacf
updating BC far-field for multicomponent flows
Cristopher-Morales Jun 18, 2025
ae24537
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jun 18, 2025
b7b03db
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Jun 18, 2025
93f70ab
fix small bug conductivity prandtl
Cristopher-Morales Jun 20, 2025
4b1fb41
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jun 24, 2025
8a31e7e
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jun 27, 2025
b47abcf
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jun 27, 2025
8640efd
adding regression cases
Cristopher-Morales Jun 27, 2025
a25de29
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jun 30, 2025
c0b0bed
update residual JST-Lax_Friedrich
Cristopher-Morales Jun 30, 2025
f1744c0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 2, 2025
ae3ab31
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 7, 2025
c2a572b
adding GetValue for DA in FluidCantera
Cristopher-Morales Jul 7, 2025
67ba8be
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Jul 7, 2025
827f640
adding constructor when SU2 is not compile with Cantera
Cristopher-Morales Jul 11, 2025
3148c3a
adding function for computing enthalpy due to species diffusion
Cristopher-Morales Jul 12, 2025
f962f0b
removing getvalue
Cristopher-Morales Jul 12, 2025
69d4efa
adding setTDState_h for multicomponent
Cristopher-Morales Jul 13, 2025
500a663
updating to develop
Cristopher-Morales Jul 13, 2025
bdf7d27
updating to feature_preconditioning
Cristopher-Morales Jul 14, 2025
749466f
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jul 14, 2025
b337c38
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Jul 14, 2025
346a511
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 15, 2025
a2b817f
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Jul 15, 2025
bcfec92
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 17, 2025
1cfbb67
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 18, 2025
7a6ddfc
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 21, 2025
310dbe0
small fix
Cristopher-Morales Jul 21, 2025
8c326e3
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Jul 21, 2025
729e594
updating headers CFluidCantera to subprojects/cantera
Cristopher-Morales Jul 26, 2025
c7f27da
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 28, 2025
a8c69ae
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Jul 31, 2025
982fb56
updating parallel_regresion residuals
Jul 31, 2025
a6a5b4e
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Aug 4, 2025
08de05d
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales Aug 4, 2025
51a577a
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales Aug 4, 2025
0f7f92c
meson options
Cristopher-Morales Aug 5, 2025
5f45862
cleaning time integration
Cristopher-Morales Aug 5, 2025
503d955
cleaning grad_chemical_source_term
Cristopher-Morales Aug 5, 2025
0a033a9
cleaning temperature limits and Relaxation factor
Cristopher-Morales Aug 11, 2025
18792df
update multizone restart for species transport
Aug 21, 2025
5fa9236
updating residual multizone species transport
Aug 21, 2025
1b52536
Update SU2_CFD/include/numerics/CNumerics.hpp
Cristopher-Morales Aug 25, 2025
47e77c7
Update SU2_CFD/include/numerics/CNumerics.hpp
Cristopher-Morales Aug 25, 2025
f99a541
Update SU2_CFD/src/fluid/CFluidScalar.cpp
Cristopher-Morales Aug 25, 2025
d3496d6
Update SU2_CFD/src/numerics/CNumerics.cpp
Cristopher-Morales Aug 25, 2025
d45faef
fixing names according to review comment
Cristopher-Morales Aug 25, 2025
b81cd1b
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Aug 26, 2025
bbb0882
fixing ComputeConsistentExtrapolation according to review comment
Cristopher-Morales Aug 26, 2025
982b649
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Aug 26, 2025
0e74342
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Aug 27, 2025
62fd167
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Aug 29, 2025
0025691
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Aug 31, 2025
9e49e7a
adding max changes
Cristopher-Morales Sep 1, 2025
65a1802
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Sep 1, 2025
12c3290
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Sep 2, 2025
24c8d3f
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Sep 2, 2025
d66fceb
removing WorkingVar from numerics and small cleaning
Cristopher-Morales Sep 3, 2025
065806c
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Sep 3, 2025
8ba4b78
formatting
Cristopher-Morales Sep 10, 2025
a3e84af
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Sep 10, 2025
eaf4970
fixing unit test for cantera
Cristopher-Morales Sep 10, 2025
8ce7ba3
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Sep 11, 2025
b2459b6
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Sep 11, 2025
a3481f4
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Sep 15, 2025
aef1ffe
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Sep 16, 2025
4fc40d5
cleaning
Cristopher-Morales Sep 16, 2025
745cf5a
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Sep 19, 2025
6e9383c
fix preaccumulation
Cristopher-Morales Sep 22, 2025
ae50195
makinf mass fractions a static array
Cristopher-Morales Sep 23, 2025
d98ed42
add preaccumulaiton in SetTDState_T
Cristopher-Morales Sep 23, 2025
18a4348
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Sep 24, 2025
da4ab08
updating residuals
Cristopher-Morales Sep 24, 2025
551ef76
removing unnecesary pointers
Cristopher-Morales Sep 24, 2025
69ec88d
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Sep 25, 2025
91477ee
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales Oct 2, 2025
8081a1b
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales Oct 3, 2025
a2cf4fd
fixing spark ignition
Cristopher-Morales Oct 3, 2025
8becc61
comment out setPreacc on SetTDState in CFluidCantera.cpp
Cristopher-Morales Oct 6, 2025
27be61a
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Oct 10, 2025
f297c97
adding vector enthalpiesSpecies and specificHeatSpecies
Cristopher-Morales Oct 10, 2025
82fad0f
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Oct 31, 2025
3407755
fixing iDim
Cristopher-Morales Oct 31, 2025
7ec5676
adding strong maker for isothermal wall
Cristopher-Morales Oct 31, 2025
530997b
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Nov 12, 2025
d075fcb
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Dec 18, 2025
69da36b
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Dec 18, 2025
65f7634
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Dec 19, 2025
b6e8678
updating cantera for turbulence and adding flag for combustion
Cristopher-Morales Dec 19, 2025
eccf972
adding speciesIndices
Cristopher-Morales Dec 19, 2025
8f01f3e
adding SetMassFractions function
Cristopher-Morales Dec 19, 2025
5230586
removing nsp and using ARRAYSIZE instead
Cristopher-Morales Dec 20, 2025
a22a3bb
cleaning, reformulating and reducing calls
Cristopher-Morales Jan 11, 2026
64d527a
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Jan 11, 2026
df65564
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Jan 12, 2026
6c46771
update version
Cristopher-Morales Jan 12, 2026
224d862
cleaning
Cristopher-Morales Jan 12, 2026
876aa54
spelling fixes
Cristopher-Morales Jan 12, 2026
9aeac3b
fixing unit test meson.build
Cristopher-Morales Jan 12, 2026
04cdc9e
additional cleaning
Cristopher-Morales Jan 12, 2026
57e1b42
improve explanation
Cristopher-Morales Jan 12, 2026
aaf9089
only add cantera_ad dependency when enable-autodiff is true
Cristopher-Morales Jan 12, 2026
ef7546b
removing AD options
Cristopher-Morales Jan 13, 2026
13bb2f5
removing flux mass correction due to diffusivity for this PR
Cristopher-Morales Jan 15, 2026
9bcd2bd
small cleaning
Cristopher-Morales Jan 15, 2026
72ce6c2
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Jan 15, 2026
818d991
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Jan 19, 2026
b3db5e2
updating test case
Cristopher-Morales Jan 19, 2026
9905d99
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales Jan 20, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
[submodule "subprojects/CoolProp"]
path = subprojects/CoolProp
url = https://github.com/CoolProp/CoolProp.git
[submodule "subprojects/cantera"]
path = subprojects/cantera
url = https://github.com/cantera/cantera.git
[submodule "externals/opdi"]
path = externals/opdi
url = https://github.com/SciCompKL/OpDiLib
Expand Down
50 changes: 49 additions & 1 deletion Common/include/CConfig.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,14 @@
su2double EA_ScaleFactor; /*!< \brief Equivalent Area scaling factor */
su2double AdjointLimit; /*!< \brief Adjoint variable limit */
string* ConvField; /*!< \brief Field used for convergence check.*/
string FluidName; /*!< \brief name of the applied fluid. */
string FluidName; /*!< \brief name of the applied fluid. */
string TransportModel; /*!< \brief name transport model used in Cantera. */
string* GasCompositionNames; /*!< \brief gas composition used in Cantera. */
string ChemicalMechanismFile; /*!< \brief Chemical Reaction mechanism used in Cantera. */
string PhaseName; /*!< \brief Name of the phase in the chemical mechanism file used in Cantera. */
unsigned short n_GasCompositionNames; /*!<\brief Number of gases in mixture composition for Cantera. */
bool Combustion; /*!< \brief Flag for Combustion Detailed chemistry problems using Cantera. */
su2double Spark_Temperature; /*!< \bried Spark temperature used for ignition in detailed chemistry using Cantera. */

string* WndConvField; /*!< \brief Function where to apply the windowed convergence criteria for the time average of the unsteady (single zone) flow problem. */
unsigned short nConvField; /*!< \brief Number of fields used to monitor convergence.*/
Expand Down Expand Up @@ -4016,6 +4023,47 @@
*/
string GetFluid_Name(void) const { return FluidName; }

/*!
* \brief Returns the transport model used in Cantera.
*/
string GetTransport_Model(void) const { return TransportModel; }

/*!
* \brief Returns the chemical reaction mechanism (mechanism.yaml) used in Cantera.
*/
string GetChemical_MechanismFile(void) const { return ChemicalMechanismFile; }

/*!
* \brief Returns the name of the pase in the chemical reaction mechanism file used in Cantera.
*/
string GetPhase_Name(void) const { return PhaseName; }

/*!
* \brief Returns the gas composition used in Cantera.
*/
string GetChemical_GasComposition(unsigned short val_index = 0) const { return GasCompositionNames[val_index]; }

/*!
* \brief Set the gas composition used in Cantera.
*/
void SetChemical_GasComposition(unsigned short val_index, string gas_composition) const {
GasCompositionNames[val_index] = gas_composition;
}

/*!
* \brief Get information about the Combustion-Detailed chemistry using Cantera.
* \return <code>TRUE</code> if combustion-detailed chemistry using Cantera is used; otherwise <code>FALSE</code>.
*/
bool GetCombustion(void) const { return Combustion; }

/*!
* \brief Get High temperature applied during spark ignition.
* \return Spark Temperature.
*/
const su2double GetSpark_Temperature(void) const {

Check warning

Code scanning / CodeQL

Constant return type on member Warning

The 'const' modifier has no effect on return types. The 'const' modifying the return type can be removed.

Copilot Autofix

AI 2 days ago

In general, to fix this kind of issue you should remove any top-level const qualifier on a value return type, and, if the intention was to have a const member function, ensure the const appears after the parameter list instead. For pointer or reference return types, you should only remove the superfluous outer const and leave any meaningful inner qualifiers.

For this specific case, GetSpark_Temperature is declared as const su2double GetSpark_Temperature(void) const. The method is already correctly marked as a const member function by the trailing const. The leading const before su2double is the superfluous qualifier that CodeQL is complaining about. The best fix without changing runtime behavior is to remove that leading const, leaving the function as su2double GetSpark_Temperature(void) const { ... }. No other code or imports are required.

Only one region in Common/include/CConfig.hpp needs to be edited: the declaration/definition of GetSpark_Temperature around line 4063. We simply adjust the signature; the body and all surrounding code remain unchanged.

Suggested changeset 1
Common/include/CConfig.hpp

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/Common/include/CConfig.hpp b/Common/include/CConfig.hpp
--- a/Common/include/CConfig.hpp
+++ b/Common/include/CConfig.hpp
@@ -4060,7 +4060,7 @@
    * \brief Get High temperature applied during spark ignition.
    * \return Spark Temperature.
    */
-  const su2double GetSpark_Temperature(void) const {
+  su2double GetSpark_Temperature(void) const {
     return Spark_Temperature;
   }
 
EOF
@@ -4060,7 +4060,7 @@
* \brief Get High temperature applied during spark ignition.
* \return Spark Temperature.
*/
const su2double GetSpark_Temperature(void) const {
su2double GetSpark_Temperature(void) const {
return Spark_Temperature;
}

Copilot is powered by AI and may make mistakes. Always verify output.
return Spark_Temperature;
}

/*!
* \brief Option to define the density model for incompressible flows.
* \return Density model option
Expand Down
8 changes: 8 additions & 0 deletions Common/include/option_structure.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,7 @@ enum ENUM_FLUIDMODEL {
COOLPROP = 10, /*!< \brief Thermodynamics library. */
FLUID_FLAMELET = 11, /*!< \brief lookup table (LUT) method for premixed flamelets. */
DATADRIVEN_FLUID = 12, /*!< \brief multi-layer perceptron driven fluid model. */
FLUID_CANTERA = 13, /*!< \brief Reacting flows model. */
};
static const MapType<std::string, ENUM_FLUIDMODEL> FluidModel_Map = {
MakePair("STANDARD_AIR", STANDARD_AIR)
Expand All @@ -566,6 +567,7 @@ static const MapType<std::string, ENUM_FLUIDMODEL> FluidModel_Map = {
MakePair("COOLPROP", COOLPROP)
MakePair("DATADRIVEN_FLUID", DATADRIVEN_FLUID)
MakePair("FLUID_FLAMELET", FLUID_FLAMELET)
MakePair("FLUID_CANTERA", FLUID_CANTERA)
};

/*!
Expand Down Expand Up @@ -672,13 +674,15 @@ enum class VISCOSITYMODEL {
POLYNOMIAL, /*!< \brief Polynomial viscosity. */
FLAMELET, /*!< \brief LUT method for flamelets */
COOLPROP, /*!< \brief CoolProp viscosity. */
CANTERA, /*!< \brief Cantera viscosity. */
};
static const MapType<std::string, VISCOSITYMODEL> ViscosityModel_Map = {
MakePair("CONSTANT_VISCOSITY", VISCOSITYMODEL::CONSTANT)
MakePair("SUTHERLAND", VISCOSITYMODEL::SUTHERLAND)
MakePair("POLYNOMIAL_VISCOSITY", VISCOSITYMODEL::POLYNOMIAL)
MakePair("FLAMELET", VISCOSITYMODEL::FLAMELET)
MakePair("COOLPROP", VISCOSITYMODEL::COOLPROP)
MakePair("CANTERA", VISCOSITYMODEL::CANTERA)
};

/*!
Expand All @@ -702,13 +706,15 @@ enum class CONDUCTIVITYMODEL {
POLYNOMIAL, /*!< \brief Polynomial thermal conductivity. */
FLAMELET, /*!< \brief LUT method for flamelets */
COOLPROP, /*!< \brief COOLPROP thermal conductivity. */
CANTERA, /*!< \brief CANTERA thermal conductivity. */
};
static const MapType<std::string, CONDUCTIVITYMODEL> ConductivityModel_Map = {
MakePair("CONSTANT_CONDUCTIVITY", CONDUCTIVITYMODEL::CONSTANT)
MakePair("CONSTANT_PRANDTL", CONDUCTIVITYMODEL::CONSTANT_PRANDTL)
MakePair("POLYNOMIAL_CONDUCTIVITY", CONDUCTIVITYMODEL::POLYNOMIAL)
MakePair("FLAMELET", CONDUCTIVITYMODEL::FLAMELET)
MakePair("COOLPROP", CONDUCTIVITYMODEL::COOLPROP)
MakePair("CANTERA", CONDUCTIVITYMODEL::CANTERA)
};

/*!
Expand All @@ -732,6 +738,7 @@ enum class DIFFUSIVITYMODEL {
UNITY_LEWIS, /*!< \brief Unity Lewis model for mass diffusion in scalar transport. */
CONSTANT_LEWIS, /*!< \brief Different Lewis number model for mass diffusion in scalar transport. */
FLAMELET, /*!< \brief flamelet model for tabulated chemistry, diffusivity from lookup table */
CANTERA, /*!< \brief Mixture average diffusivity from CANTERA */
};

static const MapType<std::string, DIFFUSIVITYMODEL> Diffusivity_Model_Map = {
Expand All @@ -740,6 +747,7 @@ static const MapType<std::string, DIFFUSIVITYMODEL> Diffusivity_Model_Map = {
MakePair("UNITY_LEWIS", DIFFUSIVITYMODEL::UNITY_LEWIS)
MakePair("CONSTANT_LEWIS", DIFFUSIVITYMODEL::CONSTANT_LEWIS)
MakePair("FLAMELET", DIFFUSIVITYMODEL::FLAMELET)
MakePair("CANTERA", DIFFUSIVITYMODEL::CANTERA)
};

/*!
Expand Down
80 changes: 78 additions & 2 deletions Common/src/CConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,20 @@ void CConfig::SetConfig_Options() {
/*!\brief FLUID_NAME \n DESCRIPTION: Fluid name \n OPTIONS: see coolprop homepage \n DEFAULT: nitrogen \ingroup Config*/
addStringOption("FLUID_NAME", FluidName, string("nitrogen"));

/*!\par CONFIG_CATEGORY: Cantera fluid model \ingroup Config*/
/*!\brief TRANSPORT_MODEL \n DESCRIPTION: Transport model \n OPTIONS: see Cantera homepage \n DEFAULT: mixture-averaged \ingroup Config*/
addStringOption("TRANSPORT_MODEL", TransportModel, string("mixture-averaged"));
/*!\brief CHEMICAL_MECHANISM_FILE \n DESCRIPTION: Chemical reaction mechanism \n OPTIONS: see Cantera homepage \n DEFAULT: h2o2.yaml \ingroup Config*/
addStringOption("CHEMICAL_MECHANISM_FILE", ChemicalMechanismFile, string("h2o2.yaml"));
/*!\brief PHASE_NAME \n DESCRIPTION: name of the phase in the chemical mechanism file \n OPTIONS: see Cantera homepage \n DEFAULT: gri30 \ingroup Config*/
addStringOption("PHASE_NAME", PhaseName, string("ohmech"));
/*!\brief GAS_COMPOSITION_NAMES \n DESCRIPTION: Gas composition names \n OPTIONS: see Cantera homepage \n DEFAULT: \ingroup Config*/
addStringListOption("GAS_COMPOSITION_NAMES", n_GasCompositionNames, GasCompositionNames);
/*\brief COMBUSTION \n DESCRIPTION: Combustion Detailed chemistry using Cantera \n DEFAULT: false \ingroup Config*/
addBoolOption("COMBUSTION", Combustion, false);
/*!\brief SPARK_TEMPERATURE \n DESCRIPTION: Spark temperature used for ignition in detailed chemistry using Cantera \n DEFAULT: 1000 K \ingroup Config*/
addDoubleOption("SPARK_TEMPERATURE", Spark_Temperature, 1000.0);

/*!\par CONFIG_CATEGORY: Data-driven fluid model parameters \ingroup Config*/
/*!\brief INTERPOLATION_METHOD \n DESCRIPTION: Interpolation method used to determine the thermodynamic state of the fluid. \n OPTIONS: See \link DataDrivenMethod_Map \endlink DEFAULT: MLP \ingroup Config*/
addEnumOption("INTERPOLATION_METHOD",datadriven_ParsedOptions.interp_algorithm_type, DataDrivenMethod_Map, ENUM_DATADRIVEN_METHOD::LUT);
Expand Down Expand Up @@ -3485,7 +3499,8 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
(Kind_FluidModel == FLUID_MIXTURE) ||
(Kind_FluidModel == FLUID_FLAMELET) ||
(Kind_FluidModel == INC_IDEAL_GAS_POLY) ||
(Kind_FluidModel == CONSTANT_DENSITY));
(Kind_FluidModel == CONSTANT_DENSITY)||
(Kind_FluidModel == FLUID_CANTERA));
bool noneq_gas = ((Kind_FluidModel == MUTATIONPP) ||
(Kind_FluidModel == SU2_NONEQ));
bool standard_air = ((Kind_FluidModel == STANDARD_AIR));
Expand Down Expand Up @@ -4155,6 +4170,67 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
}
}

if ((Kind_FluidModel != FLUID_CANTERA) && (Combustion == true)) {
SU2_MPI::Error(
"The use of COMBUSTION=YES requires the use of FLUID_MIXTURE=FLUID_CANTERA,\n"
"detailed chemistry cannot be performed with other fluid models",
CURRENT_FUNCTION);
}

if ((flamelet_ParsedOptions.ignition_method != FLAMELET_INIT_TYPE::SPARK) && (Combustion == true)) {
SU2_MPI::Error(
"The use of COMBUSTION=YES requires the use of FLAME_INIT_METHOD=SPARK,\n"
"Other ignition methods are not currently available",
CURRENT_FUNCTION);
}

if (Kind_FluidModel == FLUID_CANTERA) {
/*--- Check whether the number of entries of the GAS_COMPOSITION_NAMES equals the number of transported scalar
equations solved + 1.--- */
if (n_GasCompositionNames != nSpecies_Init + 1) {
SU2_MPI::Error(
"The use of FLUID_CANTERA requires the number of entries for GAS_COMPOSITION_NAMES,\n"
"to be equal to the number of entries of SPECIES_INIT + 1",
CURRENT_FUNCTION);
}
/*--- Check whether the density model used is correct, in the case of FLUID_CANTERA the density model must be
VARIABLE. Otherwise, if the density model is CONSTANT, the scalars will not have influence the mixture density
and it will remain constant through the complete domain. --- */
if (Kind_DensityModel != INC_DENSITYMODEL::VARIABLE) {
SU2_MPI::Error("The use of FLUID_CANTERA requires the INC_DENSITY_MODEL option to be VARIABLE",
CURRENT_FUNCTION);
}
/*--- Check whether the Kind scalar model used is correct, in the case of FLUID_CANTERA the kind scalar model must
be SPECIES_TRANSPORT. Otherwise, if the scalar model is NONE, the species transport equations will not be solved.
--- */
if (Kind_Species_Model != SPECIES_MODEL::SPECIES_TRANSPORT) {
SU2_MPI::Error("The use of FLUID_CANTERA requires the KIND_SCALAR_MODEL option to be SPECIES_TRANSPORT",
CURRENT_FUNCTION);
}

if (Ref_Inc_NonDim != DIMENSIONAL) {
SU2_MPI::Error(
"The use of FLUID_CANTERA requiere the option INC_NONDIM= DIMENSIONAL, the nondimensionalization is "
"currently unavailable.",
CURRENT_FUNCTION);
}

if (Kind_ConductivityModel != CONDUCTIVITYMODEL::CANTERA) {
SU2_MPI::Error("The use of FLUID_CANTERA requires the CONDUCTIVITY_MODEL option to be CANTERA",
CURRENT_FUNCTION);
}

if (Kind_ViscosityModel != VISCOSITYMODEL::CANTERA) {
SU2_MPI::Error("The use of FLUID_CANTERA requires the VISCOSITY_MODEL option to be CANTERA",
CURRENT_FUNCTION);
}

if (Kind_Diffusivity_Model != DIFFUSIVITYMODEL::CANTERA) {
SU2_MPI::Error("The use of FLUID_CANTERA requires the DIFFUSIVITY_MODEL option to be CANTERA",
CURRENT_FUNCTION);
}
}


if (Kind_Species_Model == SPECIES_MODEL::FLAMELET) {

Expand Down Expand Up @@ -5221,7 +5297,7 @@ void CConfig::SetPostprocessing(SU2_COMPONENT val_software, unsigned short val_i
}

if (Kind_DensityModel == INC_DENSITYMODEL::VARIABLE) {
if (Kind_FluidModel != INC_IDEAL_GAS && Kind_FluidModel != INC_IDEAL_GAS_POLY && Kind_FluidModel != FLUID_MIXTURE && Kind_FluidModel != FLUID_FLAMELET) {
if (Kind_FluidModel != INC_IDEAL_GAS && Kind_FluidModel != INC_IDEAL_GAS_POLY && Kind_FluidModel != FLUID_MIXTURE && Kind_FluidModel != FLUID_FLAMELET && Kind_FluidModel != FLUID_CANTERA) {
SU2_MPI::Error("Variable density incompressible solver limited to ideal gases.\n Check the fluid model options (use INC_IDEAL_GAS, INC_IDEAL_GAS_POLY).", CURRENT_FUNCTION);
}
}
Expand Down
Loading
Loading