-
Notifications
You must be signed in to change notification settings - Fork 918
[WIP] Adding Cantera fluid model for incompressible reacting flows #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cristopher-Morales
wants to merge
286
commits into
develop
Choose a base branch
from
feature_CANTERA_PR
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,416
−54
Open
Changes from all commits
Commits
Show all changes
286 commits
Select commit
Hold shift + click to select a range
b12d561
adding diffusivity models for CANTERA
Cristopher-Morales 74b5343
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 51a854b
showing error when INC_NONDIM is INITIAL_VALUES or REFERENCE_VALUES
Cristopher-Morales e162329
reducing some pointers and arrays needed
Cristopher-Morales 46b4746
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 6ad4e5d
version updated
Cristopher-Morales a555012
adding unit test case Cantera
Cristopher-Morales f76cbd8
adding chemical source term to species transport
Cristopher-Morales dfed203
define DIFFUSIVITY_MODEL=CANTERA , transport model defines the diffus…
Cristopher-Morales df2ea0c
adding chemical source term
Cristopher-Morales a361e84
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales e68a17a
adding source terms as outputs
Cristopher-Morales 24ffda2
adding ignition and saving marker inlet composition for future implem…
Cristopher-Morales 368d602
adding gas names to outputs for cantera, adding SetChemical_GasCompos…
Cristopher-Morales 66e67ac
adding species name to flow and adjoint outputs
Cristopher-Morales f1d661d
adding gas names to SURFACE_SPECIES outputs in history.csv
Cristopher-Morales 9a43e24
small fix init.py
Cristopher-Morales bdb42ce
adding heat release
Cristopher-Morales ca9083e
solving for enthalpy
Cristopher-Morales 0487a68
fixing flux jacobian
Cristopher-Morales dd369bb
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 6fcab1a
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 5076f9d
fix output error
Cristopher-Morales 09fe6f4
adding enthalpy diffusion
Cristopher-Morales 851b13f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales b507934
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales f258308
moving enthalpy diffusion terms to CIncNSSolver.cpp
Cristopher-Morales 63a8f37
small fix
Cristopher-Morales cb1d3ef
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales f290e08
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales c254983
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 481db68
adding enthalpy and gradient diffusivities
Cristopher-Morales 573cefc
increasing MAXNVAR in scalar convection and diffusion
Cristopher-Morales 30d0b88
cleaning and rewritting some functions
Cristopher-Morales a8af977
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales e002990
adding heat release as an output
Cristopher-Morales b4d659d
setting enthalpy, temperature and thermochemical properties for ignit…
Cristopher-Morales 86de2fb
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales dd22fcd
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 59d42d9
updating test case multicomponent cantera
Cristopher-Morales 7f92730
axisymetric source term and corrected flux jacobian at the wall
Cristopher-Morales dfaa6be
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales e54bdea
adding axisymmetric source term
Cristopher-Morales cec0868
update BC_ConjugateHeat_Interface for enthalpy equation
Cristopher-Morales fdbb9b9
updating BC_ConjugateHeat_Interface for fluid mixture
Cristopher-Morales dc66d0c
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales c0b10a6
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 70bb3d4
setting formation enthalpies and fixing heat release
Cristopher-Morales 911c996
Merge branch 'develop' into feature_preconditioning
2af10c3
activating muscl, consistent extrapolation for multicomponent
d0d0221
Merge branch 'develop' into feature_preconditioning
a1f526c
correct average enthalpy for multicomponent flows output
15dd3a6
small fix chemical source term
Cristopher-Morales c469d32
Merge branch 'develop' into feature_preconditioning
ef2dc5f
changing boolean names
94bd0b0
up to date to develop
280a35d
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales ea68c00
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 1c44044
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 912642b
adding brackets
Cristopher-Morales a6ce2d4
fixing warning
Cristopher-Morales e9d1e1f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 127df29
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 211dda0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales b47e3de
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales d568a9e
updating to develop and preconditioning branch
Cristopher-Morales 058c0ef
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 3793d13
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 0655c99
adding standard reference temperature T0=298.15K as default value
Cristopher-Morales 3a2f546
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales a14446c
adding jacobian chemical source term (testing)
Cristopher-Morales b8b45ef
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales ec1ef48
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales aca6e19
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 2491f26
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 5c656bb
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 9d17cb2
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 3f45e1c
reformulating and cleaning
Cristopher-Morales b1fc9d4
cleaning flow_diffusion.hpp and .cpp
Cristopher-Morales b23913a
removing spaces
Cristopher-Morales b50088d
up-to-date with feature preconditioning
Cristopher-Morales 57d8aab
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 1961b08
fix description working variable
Cristopher-Morales 8dff31b
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 02e5eac
update parallel regresion test
Cristopher-Morales 810d2df
fix non-dimensionalization issue
Cristopher-Morales 4e9f412
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 70ae6ee
updating species Non-Dimensional test case
Cristopher-Morales 89c3e12
cleaning and updating to feature_preconditioning
Cristopher-Morales e9d3f4c
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 165a9ad
fix parallel_regression.py
Cristopher-Morales eabaabf
updating regression test cases
Cristopher-Morales ea01b35
updating to preconditioning
Cristopher-Morales 3a004be
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 053eabd
adding underelaxation factor option
Cristopher-Morales 36566b7
adding lowerlimit for underrelaxation factor
Cristopher-Morales 96c6219
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales e254dbd
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales e1d873b
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales b2efd4a
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales bbb76ae
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales aad36d1
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 52a1689
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 75e3c71
add EPS species transport
Cristopher-Morales 282396a
unable gradient chemical source term
Cristopher-Morales 56f0d86
undo EPS change
Cristopher-Morales 5eec6ad
enable chemical gradient
Cristopher-Morales 8d829b2
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 2711d27
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 1b7bba0
adding mass flux correction continuity equation
Cristopher-Morales 8a6b0f0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales f03f649
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 6a54f9f
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 5ce0c57
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 761a3ac
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 72046b0
test source average
Cristopher-Morales 1304b05
undo average source term and retrieving delta time
Cristopher-Morales 1e624d2
test bash reactor
Cristopher-Morales 0da0297
set temperature limit
Cristopher-Morales fc0419f
recomputation source terms batch reactor
Cristopher-Morales b429804
small fix
Cristopher-Morales de7879a
test computing mean integral
Cristopher-Morales 31b6101
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 91757d0
chemical source
Cristopher-Morales be00947
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales c7ff2bf
updating with develop
Cristopher-Morales 52982a4
updating to develop
Cristopher-Morales 7b27fe7
deleting chemical dictionary
Cristopher-Morales c12f5f6
test source term
Cristopher-Morales e537bb2
cleaning
Cristopher-Morales ca43883
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales f1ddb3c
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales d0f5577
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales f821c84
adding option time integration
Cristopher-Morales c6635a9
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 4428a03
update parallel regression test
Cristopher-Morales faa4cdb
adding temperature limits incompressible solver
Cristopher-Morales 395430d
adding adj enthalpy fields for incompressible solver
Cristopher-Morales 247e64b
adding HeatFluxDiffusion in Preaccumulation
Cristopher-Morales f232ff5
updating to preconditioning branch
Cristopher-Morales fcacd18
updating JST and Lax-Friedrich
Cristopher-Morales 5e1dacf
updating BC far-field for multicomponent flows
Cristopher-Morales ae24537
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales b7b03db
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 93f70ab
fix small bug conductivity prandtl
Cristopher-Morales 4b1fb41
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 8a31e7e
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales b47abcf
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 8640efd
adding regression cases
Cristopher-Morales a25de29
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales c0b0bed
update residual JST-Lax_Friedrich
Cristopher-Morales f1744c0
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales ae3ab31
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales c2a572b
adding GetValue for DA in FluidCantera
Cristopher-Morales 67ba8be
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 827f640
adding constructor when SU2 is not compile with Cantera
Cristopher-Morales 3148c3a
adding function for computing enthalpy due to species diffusion
Cristopher-Morales f962f0b
removing getvalue
Cristopher-Morales 69d4efa
adding setTDState_h for multicomponent
Cristopher-Morales 500a663
updating to develop
Cristopher-Morales bdf7d27
updating to feature_preconditioning
Cristopher-Morales 749466f
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales b337c38
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 346a511
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales a2b817f
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales bcfec92
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 1cfbb67
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 7a6ddfc
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 310dbe0
small fix
Cristopher-Morales 8c326e3
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 729e594
updating headers CFluidCantera to subprojects/cantera
Cristopher-Morales c7f27da
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales a8c69ae
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 982fb56
updating parallel_regresion residuals
a6a5b4e
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 08de05d
Merge branch 'develop' into feature_CANTERA
Cristopher-Morales 51a577a
Merge branch 'feature_preconditioning' into feature_CANTERA
Cristopher-Morales 0f7f92c
meson options
Cristopher-Morales 5f45862
cleaning time integration
Cristopher-Morales 503d955
cleaning grad_chemical_source_term
Cristopher-Morales 0a033a9
cleaning temperature limits and Relaxation factor
Cristopher-Morales 18792df
update multizone restart for species transport
5fa9236
updating residual multizone species transport
1b52536
Update SU2_CFD/include/numerics/CNumerics.hpp
Cristopher-Morales 47e77c7
Update SU2_CFD/include/numerics/CNumerics.hpp
Cristopher-Morales f99a541
Update SU2_CFD/src/fluid/CFluidScalar.cpp
Cristopher-Morales d3496d6
Update SU2_CFD/src/numerics/CNumerics.cpp
Cristopher-Morales d45faef
fixing names according to review comment
Cristopher-Morales b81cd1b
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales bbb0882
fixing ComputeConsistentExtrapolation according to review comment
Cristopher-Morales 982b649
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 0e74342
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales 62fd167
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 0025691
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 9e49e7a
adding max changes
Cristopher-Morales 65a1802
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales 12c3290
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 24c8d3f
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales d66fceb
removing WorkingVar from numerics and small cleaning
Cristopher-Morales 065806c
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales 8ba4b78
formatting
Cristopher-Morales a3e84af
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales eaf4970
fixing unit test for cantera
Cristopher-Morales 8ce7ba3
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales b2459b6
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales a3481f4
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales aef1ffe
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales 4fc40d5
cleaning
Cristopher-Morales 745cf5a
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 6e9383c
fix preaccumulation
Cristopher-Morales ae50195
makinf mass fractions a static array
Cristopher-Morales d98ed42
add preaccumulaiton in SetTDState_T
Cristopher-Morales 18a4348
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales da4ab08
updating residuals
Cristopher-Morales 551ef76
removing unnecesary pointers
Cristopher-Morales 69ec88d
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 91477ee
Merge branch 'develop' into feature_preconditioning
Cristopher-Morales 8081a1b
Merge branch 'feature_preconditioning' into feature_CANTERA_PR
Cristopher-Morales a2cf4fd
fixing spark ignition
Cristopher-Morales 8becc61
comment out setPreacc on SetTDState in CFluidCantera.cpp
Cristopher-Morales 27be61a
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales f297c97
adding vector enthalpiesSpecies and specificHeatSpecies
Cristopher-Morales 82fad0f
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales 3407755
fixing iDim
Cristopher-Morales 7ec5676
adding strong maker for isothermal wall
Cristopher-Morales 530997b
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales d075fcb
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales 69da36b
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales 65f7634
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales b6e8678
updating cantera for turbulence and adding flag for combustion
Cristopher-Morales eccf972
adding speciesIndices
Cristopher-Morales 8f01f3e
adding SetMassFractions function
Cristopher-Morales 5230586
removing nsp and using ARRAYSIZE instead
Cristopher-Morales a22a3bb
cleaning, reformulating and reducing calls
Cristopher-Morales 64d527a
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales df65564
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales 6c46771
update version
Cristopher-Morales 224d862
cleaning
Cristopher-Morales 876aa54
spelling fixes
Cristopher-Morales 9aeac3b
fixing unit test meson.build
Cristopher-Morales 04cdc9e
additional cleaning
Cristopher-Morales 57e1b42
improve explanation
Cristopher-Morales aaf9089
only add cantera_ad dependency when enable-autodiff is true
Cristopher-Morales ef7546b
removing AD options
Cristopher-Morales 13bb2f5
removing flux mass correction due to diffusivity for this PR
Cristopher-Morales 9bcd2bd
small cleaning
Cristopher-Morales 72ce6c2
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales 818d991
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales b3db5e2
updating test case
Cristopher-Morales 9905d99
Merge branch 'develop' into feature_CANTERA_PR
Cristopher-Morales File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Constant return type on member Warning
Copilot Autofix
AI 2 days ago
In general, to fix this kind of issue you should remove any top-level
constqualifier on a value return type, and, if the intention was to have a const member function, ensure theconstappears after the parameter list instead. For pointer or reference return types, you should only remove the superfluous outerconstand leave any meaningful inner qualifiers.For this specific case,
GetSpark_Temperatureis declared asconst su2double GetSpark_Temperature(void) const. The method is already correctly marked as a const member function by the trailingconst. The leadingconstbeforesu2doubleis the superfluous qualifier that CodeQL is complaining about. The best fix without changing runtime behavior is to remove that leadingconst, leaving the function assu2double GetSpark_Temperature(void) const { ... }. No other code or imports are required.Only one region in
Common/include/CConfig.hppneeds to be edited: the declaration/definition ofGetSpark_Temperaturearound line 4063. We simply adjust the signature; the body and all surrounding code remain unchanged.