Skip to content

Conversation

@ArneVoss
Copy link
Member

@ArneVoss ArneVoss commented Jun 9, 2023

Proposed Changes

To simulate a gust in CFD, typically the Field Velocity Method is used. This method prescribes a given velocity on each node and neglects any influence of the aircraft on the gust. The Split Velocity Method is an approach that allows to capture the influence of the aircraft on the gust.

As far a I understand, the Split Velocity Method is only partially implemented in SU2 and isn't used for any gust type because all gust derivatives are zero / commented out in the code. This is in line with Padron et al. (https://doi.org/10.2514/6.2014-3013) who report that "... combining the GCL with the SVM does not work."

This pull request cleans up / removes the unused code.

Related Work

The issue was identified during the work on pull request #1954

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@ArneVoss ArneVoss changed the title Removal of code related to the Split Velocity Method [WIP] Removal of code related to the Split Velocity Method Jun 9, 2023
@pcarruscag pcarruscag changed the title [WIP] Removal of code related to the Split Velocity Method Removal of code related to the Split Velocity Method Jun 11, 2023
@ArneVoss
Copy link
Member Author

Thank you for your corrections, Pedro, that's a quick pull request :)

@ArneVoss ArneVoss merged commit 6891b44 into su2code:develop Jun 12, 2023
@ArneVoss ArneVoss deleted the removal_SplitVelocityMethod branch June 12, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants