Skip to content

Conversation

@jblueh
Copy link
Contributor

@jblueh jblueh commented May 22, 2023

Proposed Changes

When accessing the adjoints, bounds checking acquires an internal lock in CoDiPack. This turned out to be a bottleneck in InitializeAdjoint and IterateDiscreteAdjoint. Therefore, we ensure sufficient size up front and skip the bounds checking.

Related Work

Previous work on hybrid parallel AD, like #1214, #1284, #1294.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh merged commit 7f36c83 into develop May 23, 2023
@jblueh jblueh deleted the hybrid_parallel_ad_perf branch May 23, 2023 09:36
@jblueh jblueh mentioned this pull request May 31, 2023
5 tasks
@jblueh jblueh mentioned this pull request Jul 26, 2023
5 tasks
@jblueh jblueh mentioned this pull request Aug 22, 2023
5 tasks
@jblueh jblueh mentioned this pull request Oct 31, 2023
6 tasks
@jblueh jblueh mentioned this pull request Nov 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants