Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1762

Cristopher-Morales · 2022-09-14T20:37:01Z

Proposed Changes

Give a brief overview of your contribution here in a few sentences.
Part 3/3 of fluid mixing model. In this part, Heat capacities and mass diffusivity based on species mass fractions have been added.

I am still working in checking the Non-dimensional case, I expect to complete it during this week.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
It is the continuation of the previous pull request of mixing density #1620 and #1690.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Common/src/CConfig.cpp

SU2_CFD/include/fluid/CConstantDiffusivity.hpp

SU2_CFD/include/fluid/CConstantSchmidt.hpp

SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

bigfooted · 2022-09-16T12:12:45Z

The naming "passive scalar' is inappropriate now. Maybe change this to 'species transport' everywhere.
Looks like you can safely do a 'search and replace all' on "passive scalar" and "PASSIVE_SCALAR"

...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg

...ansport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_heatcapacity_H2.cfg

SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp

SU2_CFD/include/fluid/CDiffusivityModel.hpp

...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg

bigfooted · 2022-10-01T08:17:38Z

@Cristopher-Morales any things left for this PR? If PASSIVE_SCALAR is changed to SPECIES_TRANSPORT, and if you have confirmed that the nondimensionalization works correctly, then from my side it will be good to go. You can put a tutorial and regression test for the adjoint optimization in the next PR.

SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp

SU2_CFD/include/fluid/CFluidModel.hpp

SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp

pcarruscag · 2022-10-01T12:17:17Z

Btw, once you think a PR is ready for another review round, leave a message or remove [WIP] from the title.

Co-authored-by: Nijso <nijso@hotmail.com>

…2_primitiveVenturi_mixingmodel_ND.cfg Co-authored-by: Nijso <nijso@hotmail.com>

SU2_CFD/include/fluid/CConstantSchmidt.hpp

SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp

SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp

TestCases/parallel_regression.py

...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg

Common/include/CConfig.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

pcarruscag

LGTM 👍

SU2_CFD/src/solvers/CIncEulerSolver.cpp

Cristopher-Morales · 2022-10-05T09:57:28Z

I have added a pull request for the Tutorials in order to change PASSIVE_SCALAR to SPECIES_TRANSPORT #27. Please let me know if it is ok to do it.

pcarruscag · 2022-10-05T13:27:23Z

Sure, is there anything on the website tutorials that needs to be updated?

Cristopher-Morales · 2022-10-05T13:36:49Z

Sure, is there anything on the website tutorials that needs to be updated?
Hi, yes in the tutorial created by Tobias the option PASSIVE_SCALAR must be changed to SPECIES_TRANSPORT. Should I do a pull request for modifying it?

pcarruscag · 2022-10-05T13:39:25Z

Of course

Cristopher-Morales added 2 commits September 14, 2022 21:57

adding commits from branch feature_massdiffusivity

06518e3

adding test cases

255a7a2

pcarruscag reviewed Sep 15, 2022

View reviewed changes

Cristopher-Morales and others added 3 commits September 15, 2022 20:55

Update Common/src/CConfig.cpp

258f573

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

adding pull request comments

17ad0e2

adding NonDimensional test case

fd8a695

bigfooted reviewed Sep 19, 2022

View reviewed changes

...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg Show resolved Hide resolved

bigfooted reviewed Sep 19, 2022

View reviewed changes

...ansport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_heatcapacity_H2.cfg Show resolved Hide resolved

Cristopher-Morales and others added 4 commits September 19, 2022 15:10

adding description test case

3cfc9c3

removing unneccesary cv implementation

9d5449d

Merge branch 'develop' into feature_mass_diffusivity

2324d7e

Merge branch 'develop' into feature_mass_diffusivity

a2126b5

pcarruscag added the changelog:feature label Sep 25, 2022

Cristopher-Morales and others added 7 commits September 26, 2022 10:04

Merge branch 'develop' into feature_mass_diffusivity

dac71cd

cleaning up and updating some implementations

0b1fe38

Merge branch 'develop' into feature_mass_diffusivity

3d39be2

Merge branch 'develop' into feature_mass_diffusivity

6b92164

change needed for Adjoint problems

3cf8d4d

Merge branch 'develop' into feature_mass_diffusivity

cfaa61b

Merge branch 'develop' into feature_mass_diffusivity

bad9629

bigfooted reviewed Oct 1, 2022

View reviewed changes

SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp Outdated Show resolved Hide resolved

bigfooted reviewed Oct 1, 2022

View reviewed changes

SU2_CFD/include/fluid/CDiffusivityModel.hpp Outdated Show resolved Hide resolved

bigfooted reviewed Oct 1, 2022

View reviewed changes

...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg Outdated Show resolved Hide resolved

bigfooted reviewed Oct 1, 2022

View reviewed changes

...es/species_transport/venturi_primitive_3species/species2_primitiveVenturi_mixingmodel_ND.cfg Outdated Show resolved Hide resolved

pcarruscag reviewed Oct 1, 2022

View reviewed changes

SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp Outdated Show resolved Hide resolved

SU2_CFD/include/fluid/CFluidModel.hpp Outdated Show resolved Hide resolved

SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp Outdated Show resolved Hide resolved

Cristopher-Morales and others added 2 commits October 3, 2022 09:12

Update SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp

89b06fa

Co-authored-by: Nijso <nijso@hotmail.com>

Update SU2_CFD/include/fluid/CDiffusivityModel.hpp

f410758

Co-authored-by: Nijso <nijso@hotmail.com>

Cristopher-Morales and others added 3 commits October 3, 2022 09:13

Update TestCases/species_transport/venturi_primitive_3species/species…

046dee9

…2_primitiveVenturi_mixingmodel_ND.cfg Co-authored-by: Nijso <nijso@hotmail.com>

Update TestCases/species_transport/venturi_primitive_3species/species…

40e8703

…2_primitiveVenturi_mixingmodel_ND.cfg Co-authored-by: Nijso <nijso@hotmail.com>

cleaning up and removing virtual function

12f9e09

pcarruscag reviewed Oct 3, 2022

View reviewed changes

Cristopher-Morales and others added 5 commits October 3, 2022 16:13

Update Common/include/CConfig.hpp

9cd40f4

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/fluid/CConstantSchmidt.hpp

f3f4253

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/fluid/CConstantSchmidtRANS.hpp

7846c85

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Update SU2_CFD/include/fluid/CUnityLewisDiffusivity.hpp

365f27b

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

removing cv implementations and updating ND case

daef990

pcarruscag changed the title ~~[WIP] Composition-dependent heat capacities and mass diffusivity models for incompresible flows~~ Composition-dependent heat capacities and mass diffusivity models for incompresible flows Oct 4, 2022

pr-triage bot added the PR: unreviewed label Oct 4, 2022

pcarruscag approved these changes Oct 4, 2022

View reviewed changes

pcarruscag requested changes Oct 4, 2022

View reviewed changes

SU2_CFD/src/solvers/CIncEulerSolver.cpp Outdated Show resolved Hide resolved

Cristopher-Morales added 2 commits October 5, 2022 09:49

undo lambda implementation

212db5f

changing PASSIVE_SCALAR to SPECIES_TRANSPORT and updating residuals

ea412aa

pcarruscag approved these changes Oct 5, 2022

View reviewed changes

Cristopher-Morales merged commit 399b73b into develop Oct 5, 2022

Cristopher-Morales deleted the feature_mass_diffusivity branch October 5, 2022 15:04

pr-triage bot added PR: merged and removed PR: unreviewed labels Oct 5, 2022

lkusch mentioned this pull request Oct 7, 2022

Source term for axisymmetry in species transport #1785

Merged

2 tasks

Cristopher-Morales mentioned this pull request Oct 11, 2022

Fixing Schmidt diffusivity model and adding option of Constant Lewis number #1787

Merged

3 tasks

Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1762

Composition-dependent heat capacities and mass diffusivity models for incompresible flows #1762

Uh oh!

Conversation

Cristopher-Morales commented Sep 14, 2022

Proposed Changes

Related Work

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigfooted commented Sep 16, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigfooted commented Oct 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag commented Oct 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pcarruscag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Cristopher-Morales commented Oct 5, 2022

Uh oh!

pcarruscag commented Oct 5, 2022

Uh oh!

Cristopher-Morales commented Oct 5, 2022

Uh oh!

pcarruscag commented Oct 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants