Collect Turb output from Comp/Inc/Nemo in CFlowOutput #1449
Conversation
Comp/Inc/Nemo kept exactly the same output for Turb stuff in their respective outputs. That is now collected and moved to the parent class. I hope the accesses to the data is the same between the 3 classes ... otherwise it wont work
One noticed small downside to this operation is that during the dry run the turb quantities are written collectively close to the end when the respective function is called. Before ALL the RMS_RES were listed close to each other.
Made sure to keep the original order, such that restarts work the same as before.
I fear, that also applies to the History output (Edit: Done in ff966f0 ) |
RMS_RES, MAX_RES, BGS_RES, TurbLINSOL are all written in separate functions.
|
But that is processed in groups, it should not have the same problem 🤔 |
I mean... it can still stay like that, or should I revert 😬 |
|
It's ok, I'll have a look today or tomorrow to see if there is some way to recover those precious deleted lines. |
|
Or I revert the History split-up and we call it a weekend |
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Registering the outputs defined the output order, but data can be loaded in any order.
TobiKattmann
left a comment
TobiKattmann
left a comment
There was a problem hiding this comment.
Big Thanks for the extensive update and the research what actually matters for the order! And of course kudos for the additional 🔴 ;)
I have no more comments or updates to make, so in case you're good I guess we can merge
| case TURB_MODEL::NONE: | ||
| /*--- Early return if there is no turbulence model in use. ---*/ | ||
| return; |
A possible idea is to make a collected ScalarResidual etc ... as opposed to a seperate SpeciesResidual and TurbResidual.
Hi,
Comp/Inc/Nemo output all had the same RMS_TKE etc output -> now this is done once in CFlowOutput and Comp/Inc/NemoOutput only call sth like
SetHistoryOutput_Turbin their respectiveSetHistoryOutput.this is just a cleanup and shouldnt change too much.
I do this in anticipation of addition of Species related output which I dont want to repeat. So #1388 will use the same concept
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.