SwitchToVR/MR via StylyXrRig #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the way passthrough mode and XR mode switching are managed in the XR rig codebase, improving encapsulation and making the
PassthroughManagermethods and properties internal. The main logic for passthrough mode is now accessed through theStylyXrRigclass, which delegates to its internalPassthroughManagerinstance. This change enhances the clarity of the public API and restricts direct access to passthrough controls.Encapsulation and API changes:
PassthroughManager.PassthroughModeproperty andSwitchToVR/SwitchToMRmethods internal, restricting their access to within the assembly. [1] [2]Delegation and initialization:
PassthroughManagerfield toStylyXrRigand initialized it inAwakeusingGetComponentInChildren. [1] [2]StylyXrRigto expose publicPassthroughModeproperty andSwitchToVR/SwitchToMRmethods, which delegate to the internalPassthroughManagerif available.Minor cleanup:
StylyXrRigfor cleaner code.Close #120