Refactor/sdk setup #103
Merged
Refactor/sdk setup #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afjk
reviewed
Sep 1, 2025
| PrepareSdkInstallation(); | ||
| if (AddUnityPackage(packageIdentifier)) { SessionState.SetBool(packageIdentifier, true); } | ||
| // Install package and assign loader | ||
| if (InstallPackageAndAssignLoaderForBuildTarget("com.unity.xr.visionos", "UnityEngine.XR.VisionOS.VisionOSLoader", BuildTargetGroup.VisionOS)) { SessionState.SetBool(packageIdentifier, true); } |
Collaborator
There was a problem hiding this comment.
"com.unity.xr.visionos" and packageIdentifier are the same.
afjk
reviewed
Sep 1, 2025
| void Step1() // Enable the OpenXR Loader | ||
| { | ||
| EnableXRPlugin(BuildTargetGroup.Standalone, typeof(OpenXRLoader)); | ||
| EnableXRPlugin(BuildTargetGroup.Android, "UnityEngine.XR.OpenXR.OpenXRLoader"); |
Collaborator
There was a problem hiding this comment.
PCVR is standalone. Why the change to Android?
Collaborator
Author
There was a problem hiding this comment.
It’s just a mistake. I’ll fix it.
Collaborator
Author
|
I fixed the wrong code in #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes
New logic for visionOS uses InstallPackageAndAssignLoaderForBuildTarget instead of EnableXRPlugin.
Details
This pull request refactors and streamlines the SDK setup logic for various XR platforms in the Styly XR Rig project. The main focus is on improving package installation and loader assignment, unifying the way XR plugins are enabled, and cleaning up unused code. Special handling is also introduced for VisionOS, reflecting its unique requirements.
SDK Setup Refactoring and Unification:
Replaced usage of
typeof(OpenXRLoader)with the string"UnityEngine.XR.OpenXR.OpenXRLoader"in allEnableXRPlugincalls, ensuring a consistent approach to enabling XR plugins across all SDK setup scripts. (SetupSdk_AndroidXR.cs,SetupSdk_MetaOpenXrSdk.cs,SetupSdk_PicoUnityOpenXrSdk.cs,SetupSdk_Template.cs,SetupSdk_ViveOpenXrPlugin.cs,SetupSdk_PcVrForDevelopment.cs) [1] [2] [3] [4] [5] [6]Removed the call to
PrepareSdkInstallation()from allInstallPackage()methods, simplifying the package installation process. (SetupSdk_AndroidXR.cs,SetupSdk_MetaOpenXrSdk.cs,SetupSdk_PicoUnityOpenXrSdk.cs,SetupSdk_Template.cs,SetupSdk_ViveOpenXrPlugin.cs,SetupSdk_PcVrForDevelopment.cs,SetupSdk_XrealSdk.cs) [1] [2] [3] [4] [5] [6] [7]VisionOS-Specific Adjustments:
"com.unity.xr.visionos"and updatedInstallPackage()to use the newInstallPackageAndAssignLoaderForBuildTargetmethod, which handles both package installation and loader assignment in one step. Also clarified that VisionOS setup differs from other SDKs and removed unnecessary code from the loader enabling step. (SetupSdk_PolySpatialVisionOS.cs) [1] [2]Core Utility Enhancements:
PrepareSdkInstallation()with a newInstallPackageAndAssignLoaderForBuildTargetmethod inSetupSdkUtils.cs, using reflection to call Unity's internal API for installing packages and assigning loaders in one atomic operation. This improves reliability and maintainability of the SDK setup process. (SetupSdkUtils.cs)Code Cleanup:
Removed the now-unused
SetupSdk.csfile and its associated.metafile, as well as the related menu item for removing all SDK packages. (SetupSdk.cs,SetupSdk.cs.meta,SetupSdkMenu.cs) [1] [2] [3]Minor import and code organization improvements, such as removing unused
UnityEditor.Renderingimport and adjusting debug menu items. (SetupSdkUtils.cs,SetupSdkMenu.cs) [1] [2]