v0.8.1

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [0.8.1] - 2021-08-12
+
+### Fixed
+
+- Juke will properly exit with a non-zero exit code if any target has failed. As before, this is overridable via `Juke.setup().then((code) => ...)`.
+
 ## [0.8.0] - 2021-08-11
 
 ### Added

build.mjs

@@ -44,11 +44,16 @@ export const BundleTarget = new Juke.Target({
       entryPoints: ['src/index.ts'],
       outfile: 'dist/index.js',
     });
-    if (String.prototype.replaceAll) {
-      const content = fs.readFileSync('dist/index.js', 'utf-8')
-        .replaceAll(process.cwd() + '/.yarn/cache/', '');
-      fs.writeFileSync('dist/index.js', content);
+    // A very crude implementation of replaceAll
+    let content = fs.readFileSync('dist/index.js', 'utf-8');
+    while (true) {
+      const nextContent = content.replace(process.cwd() + '/.yarn/cache/', '');
+      if (content === nextContent) {
+        break;
+      }
+      content = nextContent;
     }
+    fs.writeFileSync('dist/index.js', content);
   },
 });
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "juke-build",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "The AKE-less Build System for JavaScript and Node.js.",
   "keywords": [
     "build",

src/exec.ts

@@ -5,7 +5,7 @@ import { resolve as resolvePath } from 'path';
 
 const children = new Set<ChildProcess>();
 
-const killChildren = () => {
+export const killChildren = () => {
   for (const child of children) {
     child.kill('SIGTERM');
     children.delete(child);
@@ -15,7 +15,7 @@ const killChildren = () => {
 
 type SignalHandler = (signal: string) => void;
 
-const trap = (signals: string[], handler: SignalHandler) => {
+export const trap = (signals: string[], handler: SignalHandler) => {
   let readline;
   if (process.platform === 'win32') {
     readline = require('readline').createInterface({
@@ -36,25 +36,6 @@ const trap = (signals: string[], handler: SignalHandler) => {
   }
 };
 
-trap(['EXIT', 'BREAK', 'HUP', 'INT', 'TERM'], (signal) => {
-  if (signal !== 'EXIT') {
-    console.log('Received', signal);
-  }
-  killChildren();
-  if (signal !== 'EXIT') {
-    process.exit(1);
-  }
-});
-
-const exceptionHandler = (err: unknown) => {
-  console.log(err);
-  killChildren();
-  process.exit(1);
-};
-
-process.on('unhandledRejection', exceptionHandler);
-process.on('uncaughtException', exceptionHandler);
-
 export class ExitCode extends Error {
   code: number | null = null;
   signal: string | null = null;

src/index.ts

@@ -2,6 +2,7 @@ import _chalk from 'chalk';
 import { createRequire } from 'module';
 import { version } from '../package.json';
 import { chdir } from './chdir';
+import { killChildren, trap } from './exec';
 import { logger } from './logger';
 import { createParameter, Parameter } from './parameter';
 import { runner } from './runner';
@@ -22,6 +23,8 @@ export {
 
 export const chalk = _chalk;
 
+let lastExitCode: number | null = null;
+
 type SetupConfig = {
   file: string;
   /**
@@ -37,7 +40,7 @@ type SetupConfig = {
  * @param config Juke Build configuration.
  * @returns Exit code of the whole runner process.
  */
-export const setup = async (config: SetupConfig) => {
+export const setup = async (config: SetupConfig): Promise<number> => {
   logger.info(`Juke Build version ${version}`)
   if (!config.file) {
     logger.error(`Field 'file' is required in Juke.setup()`);
@@ -89,9 +92,34 @@ export const setup = async (config: SetupConfig) => {
     default: DefaultTarget,
     singleTarget: config.singleTarget,
   });
-  return runner.start();
+  return runner.start().then((code) => {
+    lastExitCode = code;
+    return code;
+  });
 };
 
 export const sleep = (time: number) => (
   new Promise((resolve) => setTimeout(resolve, time))
 );
+
+trap(['EXIT', 'BREAK', 'HUP', 'INT', 'TERM'], (signal) => {
+  if (signal !== 'EXIT') {
+    console.log('Received', signal);
+  }
+  killChildren();
+  if (signal !== 'EXIT') {
+    process.exit(1);
+  }
+  else if (lastExitCode !== null) {
+    process.exit(lastExitCode);
+  }
+});
+
+const exceptionHandler = (err: unknown) => {
+  console.log(err);
+  killChildren();
+  process.exit(1);
+};
+
+process.on('unhandledRejection', exceptionHandler);
+process.on('uncaughtException', exceptionHandler);

tools/publish.sh

@@ -20,7 +20,7 @@ fi
 
 if [[ ${from_git} == "0" ]]; then
   echo "=> Starting versioning tool"
-  yarn release-tool version
+  yarn release-tool version --yes
 fi
 
 echo "=> Pushing to git"