Fix false positives on non-standard syntax in declaration-block-no-* #3381

gucong3000 · 2018-06-09T14:51:52Z

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

alexander-akait · 2018-06-09T15:37:51Z

lib/rules/declaration-block-no-redundant-longhand-properties/__tests__/index.js

+      code:
+        "margin-left: 10px; margin-right: 10px; margin-top: 20px; margin-bottom: 30px;",
+      message: messages.expected("margin")
+    },


Let's add test with html and style tag

jeddy3

@gucong3000 Thanks for starting this.

I've added two comments about the tests. The comments apply to all the files e.g. I don't believe the following is valid syntax:

padding-top: 1px; padding-bottom: 1px; a { padding-left: 1px; padding-right: 1px; }

jeddy3 · 2018-06-10T12:41:23Z

lib/rules/declaration-block-no-duplicate-properties/__tests__/index.js

@@ -18,6 +18,10 @@ testRule(rule, {
      code: "a { color: pink; { &:hover { color: orange; } } }",
      description: "spec nested"
    },
+    {
+      code: "color: pink; @media { color: orange; }",


As per the developer guide:

Ensure you use standard CSS syntax by default

I don't believe a declaration outside of rule-set is valid. What are we trying to test here?

If it's the content of a style="" attribute then how does this differ from the syntax: html tests below which are more explicit?

jeddy3 · 2018-06-10T12:44:07Z

lib/rules/declaration-block-no-duplicate-properties/__tests__/index.js

@@ -48,6 +52,10 @@ testRule(rule, {
  ],

  reject: [
+    {
+      code: "color: pink; color: orange",


If this is for style="" attributes? If so, how does it differ from the syntax: html tests below?

jeddy3

@gucong3000 Thanks for moving the tests to their own testRule. It's much clearer what's going on now and aligns with the checklist:

Ensure you use standard CSS syntax by default, and only swap parsers when testing a specific piece of non-standard syntax.

@evilebottnawi How does this PR now look to you?

jeddy3 · 2018-06-15T12:36:28Z

@evilebottnawi If you've time to review this today, then I'll be able to do a release before I go away for the weekend.

alexander-akait · 2018-06-15T12:46:39Z

@jeddy3 LGTM

jeddy3 · 2018-06-15T13:14:12Z

Fixed: declaration-block-no-* false positives for non-standard syntax (#3381).

194: Update dependency stylelint to v9.3.0 r=rehandalal a=renovate[bot] This Pull Request updates dependency [stylelint](https://github.com/stylelint/stylelint) from `v9.2.1` to `v9.3.0` <details> <summary>Release Notes</summary> ### [`v9.3.0`](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md#930) [Compare Source](stylelint/stylelint@9.2.1...9.3.0) - Added: support for `<style>` tags and `style=""` attributes in XML and XSLT files ([#3386](`https://github.com/stylelint/stylelint/pull/3386`)). - Added: `globbyOptions` option ([#3339](`https://github.com/stylelint/stylelint/pull/3339`)). - Added: `keyframes-name-pattern` rule ([#3321](`https://github.com/stylelint/stylelint/pull/3321`)). - Added: `media-feature-name-value-whitelist` rule ([#3320](`https://github.com/stylelint/stylelint/pull/3320`)). - Added: `selector-pseudo-element-colon-notation` autofix ([#3345](`https://github.com/stylelint/stylelint/pull/3345`)). - Fixed: `.vue` files throwing errors for `<style lang="stylus">` and `<style lang="postcss">` ([#3331](`https://github.com/stylelint/stylelint/pull/3331`)). - Fixed: `declaration-block-no-*` false positives for non-standard syntax ([#3381](`https://github.com/stylelint/stylelint/pull/3381`)). - Fixed: `function-whitespace-after` false positives for "/" ([#3132](`https://github.com/stylelint/stylelint/pull/3132`)). - Fixed: `length-zero-no-unit` incorrect autofix for at-includes ([#3347](`https://github.com/stylelint/stylelint/pull/3347`)). - Fixed: `max-nesting-depth` false positives for nested properties ([#3349](`https://github.com/stylelint/stylelint/pull/3349`)). - Fixed: `no-empty-source` false positives on vue external sources `<style src="*">` tag ([#3331](`https://github.com/stylelint/stylelint/pull/3331`)). - Fixed: `max-line-length` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). - Fixed: `no-eol-whitespace` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). - Fixed: `no-extra-semicolons` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). - Fixed: `no-missing-end-of-source-newline` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>

This Pull Request updates dependency [stylelint](https://github.com/stylelint/stylelint) from `v9.2.1` to `v9.3.0` <details> <summary>Release Notes</summary> ### [`v9.3.0`](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md#930) [Compare Source](stylelint/stylelint@9.2.1...9.3.0) - Added: support for `<style>` tags and `style=""` attributes in XML and XSLT files ([#3386](`https://github.com/stylelint/stylelint/pull/3386`)). - Added: `globbyOptions` option ([#3339](`https://github.com/stylelint/stylelint/pull/3339`)). - Added: `keyframes-name-pattern` rule ([#3321](`https://github.com/stylelint/stylelint/pull/3321`)). - Added: `media-feature-name-value-whitelist` rule ([#3320](`https://github.com/stylelint/stylelint/pull/3320`)). - Added: `selector-pseudo-element-colon-notation` autofix ([#3345](`https://github.com/stylelint/stylelint/pull/3345`)). - Fixed: `.vue` files throwing errors for `<style lang="stylus">` and `<style lang="postcss">` ([#3331](`https://github.com/stylelint/stylelint/pull/3331`)). - Fixed: `declaration-block-no-*` false positives for non-standard syntax ([#3381](`https://github.com/stylelint/stylelint/pull/3381`)). - Fixed: `function-whitespace-after` false positives for "/" ([#3132](`https://github.com/stylelint/stylelint/pull/3132`)). - Fixed: `length-zero-no-unit` incorrect autofix for at-includes ([#3347](`https://github.com/stylelint/stylelint/pull/3347`)). - Fixed: `max-nesting-depth` false positives for nested properties ([#3349](`https://github.com/stylelint/stylelint/pull/3349`)). - Fixed: `no-empty-source` false positives on vue external sources `<style src="*">` tag ([#3331](`https://github.com/stylelint/stylelint/pull/3331`)). - Fixed: `max-line-length` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). - Fixed: `no-eol-whitespace` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). - Fixed: `no-extra-semicolons` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). - Fixed: `no-missing-end-of-source-newline` false positives for non-CSS blocks ([#3367](`https://github.com/stylelint/stylelint/pull/3367`)). --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

add support for non-standard declaration block

a8eb592

alexander-akait suggested changes Jun 9, 2018

View reviewed changes

jeddy3 requested changes Jun 10, 2018

View reviewed changes

jeddy3 added the PR: needs revision label Jun 10, 2018

Update testcase

c4c6c69

gucong3000 force-pushed the declaration-block branch from cd4cd67 to c4c6c69 Compare June 11, 2018 03:10

jeddy3 changed the title Fix: false positives on non-standard syntax in declaration-block-no-* Fix false positives on non-standard syntax in declaration-block-no-* Jun 12, 2018

jeddy3 removed the PR: needs revision label Jun 12, 2018

jeddy3 approved these changes Jun 12, 2018

View reviewed changes

jeddy3 mentioned this pull request Jun 12, 2018

Release 9.3 #3319

Closed

4 tasks

alexander-akait approved these changes Jun 15, 2018

View reviewed changes

jeddy3 merged commit 3507bac into master Jun 15, 2018

jeddy3 deleted the declaration-block branch June 15, 2018 13:12

This was referenced Jun 17, 2018

Update 5 dependencies from npm JetBrains/ring-ui#289

Closed

Update 6 dependencies from npm JetBrains/ring-ui#290

Merged

Update 2 dependencies from npm isoppp/nuxt-oreore-starter-kit#12

Merged

alexander-akait mentioned this pull request Aug 2, 2018

Fix false positives on non-standard syntax in declaration-block-no-* #3380

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix false positives on non-standard syntax in declaration-block-no-* #3381

Fix false positives on non-standard syntax in declaration-block-no-* #3381

gucong3000 commented Jun 9, 2018 •

edited

Loading

alexander-akait Jun 9, 2018

gucong3000 Jun 9, 2018

jeddy3 left a comment

jeddy3 Jun 10, 2018

jeddy3 Jun 10, 2018

jeddy3 left a comment

jeddy3 commented Jun 15, 2018

alexander-akait commented Jun 15, 2018

jeddy3 commented Jun 15, 2018

Fix false positives on non-standard syntax in declaration-block-no-* #3381

Fix false positives on non-standard syntax in declaration-block-no-* #3381

Conversation

gucong3000 commented Jun 9, 2018 • edited Loading

alexander-akait Jun 9, 2018

Choose a reason for hiding this comment

gucong3000 Jun 9, 2018

Choose a reason for hiding this comment

jeddy3 left a comment

Choose a reason for hiding this comment

jeddy3 Jun 10, 2018

Choose a reason for hiding this comment

jeddy3 Jun 10, 2018

Choose a reason for hiding this comment

jeddy3 left a comment

Choose a reason for hiding this comment

jeddy3 commented Jun 15, 2018

alexander-akait commented Jun 15, 2018

jeddy3 commented Jun 15, 2018

gucong3000 commented Jun 9, 2018 •

edited

Loading