Remove false props before generating styles #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liqueflies any opinion on that? |
Prevents generating `undefined` style properties e.g
`{ fontSize: '16px', fontFamily: undefined }`
The above props would generate the following styles:
```
font-size: 16px;
font-family: undefined;
```
The new feature is filtering false props before generating and injecting the styles. The new styles now look something like this:
```
font-size: 16px;
```
More details: styled-components#102
andreruffert
force-pushed
the
remove-false-props-before-generate-styles
branch
from
b548e42 to
d481383
Compare
|
can this be merged in the next release? |
liqueflies
added a commit
that referenced
this pull request
Nov 28, 2020
|
Solved merging #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a filter to remove false props to prevent generating
undefinedstyle properties.Example props
{ fontSize: '16px', fontFamily: undefined }The above props would generate the following styles:
The new feature here is filtering false props before generating and injecting the styles.
The new styles now look like this:
Related: #102