Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add additional files and folders to npmignore #553

Merged
merged 3 commits into from
Nov 21, 2020
Merged

fix: Add additional files and folders to npmignore #553

merged 3 commits into from
Nov 21, 2020

Conversation

scttcper
Copy link
Contributor

@scttcper scttcper commented Nov 20, 2020

Currently, this module is 9mb on disk. Added a bunch of stuff to .npmignore so that they aren't published.

Can check unpacked size via npm https://www.npmjs.com/package/polished
image

@scttcper scttcper requested a review from bhough as a code owner November 20, 2020 03:25
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #553 (1dbbca8) into main (2b83397) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #553   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           88        88           
  Lines          831       831           
  Branches       305       305           
=========================================
  Hits           831       831           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b83397...0661138. Read the comment docs.

@bhough
Copy link
Contributor

bhough commented Nov 20, 2020

Thanks for putting this together @scttcper. We will review, but the docs have been an often requested inclusion for offline access: #281

@scttcper
Copy link
Contributor Author

@bhough kept docs in there. The biggest issue is the .yarn folder which i assume is some sort of cache. Docs is maybe 2mb

@bhough
Copy link
Contributor

bhough commented Nov 21, 2020

@bhough kept docs in there. The biggest issue is the .yarn folder which i assume is some sort of cache. Docs is maybe 2mb

@scttcper That is a remnant of our work in the background to move to Yarn 2. We are taking the zero-install approach with polished once we swap and that folder is where it stores the cache. However, we can remove it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants