fix: comment edgecase (formatter) #1911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tippenein
commented
Jul 10, 2025
tippenein
commented
- closes Comment edited by clarity formatter #1892
tippenein
force-pushed
the
fix/comment-edgecase-1892
branch
from
cd5350c to
320a407
Compare
|
Set to draft since there's some unintended churn with golden test maps.. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tippenein
force-pushed
the
fix/comment-edgecase-1892
branch
from
61902d1 to
59d8e58
Compare
|
Hey @brady-stacks |
|
I'd love to get back to this at some point. The changes it causes in maps and newlining are quite annoying because some are improvements and some are just plain strange.. Would take some debugging to iron out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.