Fix undefined array offset in get_keymaps() after offset slicing#32
Draft
Copilot wants to merge 2 commits into
Draft
Fix undefined array offset in get_keymaps() after offset slicing#32Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: JJJ <88951+JJJ@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix undefined index notice in wp-spider-cache plugin
Fix undefined array offset in get_keymaps() after offset slicing
Dec 9, 2025
JJJ
approved these changes
Dec 9, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes "Undefined offset: 1" notices that occur in the get_keymaps() function on single-site WordPress installations when processing cache keys. After applying array_slice() to remove key prefixes, the code attempted to access array elements without proper validation.
Key Changes
- Added
empty($parts)check after offset slicing to skip malformed keys that result in empty arrays - Added
isset($parts[1])guard before accessing the second array element in the multisite code path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
get_keymaps()function throws "Undefined offset: 1" notices on single-site installations when processing cache keys. After applyingarray_slice()to remove key prefixes, the code accesses$parts[1]without validation.Changes
isset($parts[1])guard before accessing second element in multisite branchThis prevents notices while preserving existing behavior for well-formed cache keys.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.