Authenticate before the doctor Eufy-cloud check#40
Merged
Conversation
The check called fetch_measurements without authenticate() first; the real EufyClient raises "Must authenticate before fetching measurements", so a healthy setup showed a spurious FAIL (the mocked test hid the required call order). Added authenticate() and a test that pins the order past the mock. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merged
sturimcode
added a commit
that referenced
this pull request
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live run of
eufy-sync --doctorshowed a spuriousFAIL eufy cloud - Must authenticate before fetching measurements: the check calledfetch_measurementswithoutauthenticate()first, which the mocked test could not catch. Added the auth call and a test that pins the call order past the mock.🤖 Generated with Claude Code