ProcessStartInfo.ArgumentList vs. Arguments in Windows#27
Open
pryankster wants to merge 4 commits intosttz:masterfrom
Open
ProcessStartInfo.ArgumentList vs. Arguments in Windows#27pryankster wants to merge 4 commits intosttz:masterfrom
pryankster wants to merge 4 commits intosttz:masterfrom
Conversation
pryankster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows doesn't have a proper shell to speak of, and it's really bad at quoting. Was having problems with ZipDistro, so I converted the references to command line arguments in System.Diagnostics.ProcessStartInfo to use ArgumentList instead of Arguments. The elements added to ArgumentList shouldn't need to be quoted or escaped, because they will passed directly to the subprocess.
I haven't looked for other places that ProcessStartInfo is used in this project, but I assume that they would benefit from a similar treatment.